[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Default - empty char format is used for inline
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-11-18 15:41:48
Message-ID: 20101118154148.5399.8572 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-11-18 15:13:00, Thomas Zander wrote:
> > /trunk/koffice/libs/kotext/KoInlineTextObjectManager.h, line 80
> > <http://svn.reviewboard.kde.org/r/5898/diff/1/?file=41443#file41443line80>
> >
> > Please don't add a boolean to the public API; see \
> > http://chaos.troll.no/~shausman/api-design/api-design.pdf for why.
> > I suggest a char format instead.
>
> vandenoever wrote:
> Using a char for anything but ascii characters will eventually cause problems. \
> Better use an enumeration of a bool is not good.
sorry for not being clearer; I didn't mean to imply the usage of a char is correct, I \
meant to suggest the usage of a QTextCharFormat
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5898/#review8816
-----------------------------------------------------------
On 2010-11-18 11:21:01, Pavol Korinek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5898/
> -----------------------------------------------------------
>
> (Updated 2010-11-18 11:21:01)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> insertInlineObject method in KoInlineTextObjectManager class has been changed. \
> Inline object can be inserted using empty - default char format or current cursor \
> char format. Empty - default char format is used for inline (as-char) shapes now.
>
> Diffs
> -----
>
> /trunk/koffice/libs/kotext/KoInlineTextObjectManager.h 1198325
> /trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp 1198325
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1198325
>
> Diff: http://svn.reviewboard.kde.org/r/5898/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pavol
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5898/">http://svn.reviewboard.kde.org/r/5898/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 18th, 2010, 3:13 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5898/diff/1/?file=41443#file41443line80" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/libs/kotext/KoInlineTextObjectManager.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">78</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">insertInlineObject</span><span \
class="p">(</span><span class="n">QTextCursor</span> <span \
class="o">&</span><span class="n">cursor</span><span class="p">,</span> <span \
class="n">KoInlineObject</span> <span class="o">*</span><span \
class="n">object</span><span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">80</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">insertInlineObject</span><span \
class="p">(</span><span class="n">QTextCursor</span> <span \
class="o">&</span><span class="n">cursor</span><span class="p">,</span> <span \
class="n">KoInlineObject</span> <span class="o">*</span><span \
class="n">object</span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="n"><span class="hl">bool</span></span><span \
class="hl"> </span><span class="n"><span \
class="hl">useCurrentCharFormat</span></span><span class="hl"> </span><span \
class="o"><span class="hl">=</span></span><span class="hl"> </span><span \
class="nb"><span class="hl">true</span></span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please don't add a \
boolean to the public API; see \
http://chaos.troll.no/~shausman/api-design/api-design.pdf for why.
I suggest a char format instead.</pre>
</blockquote>
<p>On November 18th, 2010, 3:18 p.m., <b>vandenoever</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using a char for \
anything but ascii characters will eventually cause problems. Better use an \
enumeration of a bool is not good.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry for \
not being clearer; I didn't mean to imply the usage of a char is correct, I meant \
to suggest the usage of a QTextCharFormat</pre> <br />
<p>- Thomas</p>
<br />
<p>On November 18th, 2010, 11:21 a.m., Pavol Korinek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>
<p style="color: grey;"><i>Updated 2010-11-18 11:21:01</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">insertInlineObject method in KoInlineTextObjectManager class has been \
changed. Inline object can be inserted using empty - default char format or current \
cursor char format. Empty - default char format is used for inline (as-char) shapes \
now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/libs/kotext/KoInlineTextObjectManager.h <span style="color: \
grey">(1198325)</span></li>
<li>/trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp <span style="color: \
grey">(1198325)</span></li>
<li>/trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(1198325)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5898/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic