[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Disabling component before 2.3 release
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2010-11-18 6:25:18
Message-ID: 201011180725.19092.t.zachmann () zagge ! de
[Download RAW message or body]

Hello,

On Wednesday, November 17, 2010 09:41:58 Cyrille Berger Skott wrote:
> Since we are between the last beta and the RC it is time to disable the
> components that are not ready for releases. I suggest we discuss them in
> this thread.
> 
> The best solution is to move them to the plugins/stagging directory,
> because I will remove that directory from the release tarball, as well as
> of the branch/2.3.
> 
> If there are libraries features that are causing problems, I am not sure
> how to proceed, but we can discuss this on a case by case.

I think we should disable text on shape as it causes different problems.

- Rotatet shape that have TOS are wrongly rotated
- It is no longer possible to change the color of a shape that has TOS.
  This is a problem as nearly all shapes saved by OO have a an empty text 
connected
- Connectors with TOS are placed wrongly BUG 
- It is possible to e.g. lock the text in the document docker of 
kpresenter/karbon. However this information cannot be saved and therefore is 
lost.

I have attached a patch to disable TOS loading.

Thorsten

["disable_tos.diff" (text/x-patch)]

Index: KoTextOnShapeContainer.cpp
===================================================================
--- KoTextOnShapeContainer.cpp	(revision 1197583)
+++ KoTextOnShapeContainer.cpp	(working copy)
@@ -306,6 +306,7 @@
 // static
 void KoTextOnShapeContainer::tryWrapShape(KoShape *shape, const KoXmlElement \
&element, KoShapeLoadingContext &context)  {
+#if 0
     KoXmlElement text = KoXml::namedItemNS(element, KoXmlNS::text, "p");
     if (!text.isNull()) {
         KoShapeContainer *oldParent = shape->parent();
@@ -317,4 +318,5 @@
             delete tos;
         }
     }
+#endif
 }



_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]