'Review Request: Fix for Bug 243923'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Fix for Bug 243923
From:       "Ganesh Paramasivam" <ganesh () crystalfab ! com>
Date:       2010-11-18 5:14:38
Message-ID: 20101118051438.21969.46455 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5897/
-----------------------------------------------------------

Review request for KOffice, Thomas Zander and Ganesh Paramasivam.

Summary
-------

Fix for bug 243923 - (http://bugs.kde.org/show_bug.cgi?id=243923)
In loadParagraph check whether we are working on a existing block or a new block ( by \
checking whether the cursor's position is at the beginning of the block or not ). If \
we are working on a existing block, then don't apply the paragraph style.

This addresses bug 243923.
    https://bugs.kde.org/show_bug.cgi?id=243923

Diffs
-----

  trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1198287 

Diff: http://svn.reviewboard.kde.org/r/5897/diff

Testing
-------

Fix has been verified with the two use-cases specified in the bug report.

Thanks,

Ganesh

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5897/">http://svn.reviewboard.kde.org/r/5897/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice, Thomas Zander and Ganesh Paramasivam.</div>
<div>By Ganesh Paramasivam.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix for bug 243923 - (http://bugs.kde.org/show_bug.cgi?id=243923) In \
loadParagraph check whether we are working on a existing block or a new block ( by \
checking whether the cursor&#39;s position is at the beginning of the block or not ). \
If we are working on a existing block, then don&#39;t apply the paragraph \
style.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix has been verified with the two use-cases specified in the bug \
report.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=243923">243923</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(1198287)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5897/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 