[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: fix bug:254264,
From: "Cyrille Berger" <cberger () cberger ! net>
Date: 2010-11-15 12:51:35
Message-ID: 20101115125135.30675.41761 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-11-13 08:53:49, Boudewijn Rempt wrote:
> > I'd prefer removing the line -- and the comment, but I've tested it and=
it works.
Probably what I will do in the end :) I would feel more confident, if someo=
ne else could also test, otherwise I will commit tomorrow.
- Cyrille
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5838/#review8684
-----------------------------------------------------------
On 2010-11-12 22:46:25, Cyrille Berger wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5838/
> -----------------------------------------------------------
> =
> (Updated 2010-11-12 22:46:25)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> The attached patch fix bug:254264, that happen randomly in any koffice ap=
plication when removing a view.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/libs/main/KoMainWindow.cpp 1196098 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5838/diff
> =
> =
> Testing
> -------
> =
> In Krita, after removing a view, the window is set a minimum size, but th=
is behavior also happen without the patch (even if difficult to reproduce, =
but sometime, when I don't get the crash I can see the minimum size bug)
> =
> =
> Thanks,
> =
> Cyrille
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5838/">http://svn.reviewboard.kde.org/r/5838/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 13th, 2010, 8:53 a.m., <b>Boudewijn \
Rempt</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'd prefer removing the line -- and the comment, but I've tested \
it and it works.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Probably what I will do \
in the end :) I would feel more confident, if someone else could also test, otherwise \
I will commit tomorrow.</pre> <br />
<p>- Cyrille</p>
<br />
<p>On November 12th, 2010, 10:46 p.m., Cyrille Berger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Cyrille Berger.</div>
<p style="color: grey;"><i>Updated 2010-11-12 22:46:25</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch fix bug:254264, that happen randomly in any koffice \
application when removing a view.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In Krita, after removing a view, the window is set a minimum size, but \
this behavior also happen without the patch (even if difficult to reproduce, but \
sometime, when I don't get the crash I can see the minimum size bug)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/main/KoMainWindow.cpp <span style="color: \
grey">(1196098)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5838/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic