--===============1922550625== Content-Type: multipart/alternative; boundary="===============4363627048942142823==" --===============4363627048942142823== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-11-13 08:53:49, Boudewijn Rempt wrote: > > I'd prefer removing the line -- and the comment, but I've tested it and= it works. Probably what I will do in the end :) I would feel more confident, if someo= ne else could also test, otherwise I will commit tomorrow. - Cyrille ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5838/#review8684 ----------------------------------------------------------- On 2010-11-12 22:46:25, Cyrille Berger wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5838/ > ----------------------------------------------------------- > = > (Updated 2010-11-12 22:46:25) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > The attached patch fix bug:254264, that happen randomly in any koffice ap= plication when removing a view. > = > = > Diffs > ----- > = > trunk/koffice/libs/main/KoMainWindow.cpp 1196098 = > = > Diff: http://svn.reviewboard.kde.org/r/5838/diff > = > = > Testing > ------- > = > In Krita, after removing a view, the window is set a minimum size, but th= is behavior also happen without the patch (even if difficult to reproduce, = but sometime, when I don't get the crash I can see the minimum size bug) > = > = > Thanks, > = > Cyrille > = > --===============4363627048942142823== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5838/

On November 13th, 2010, 8:53 a.m., Boudewij= n Rempt wrote:

I'd p=
refer removing the line -- and the comment, but I've tested it and it w=
orks.
Probably wh=
at I will do in the end :) I would feel more confident, if someone else cou=
ld also test, otherwise I will commit tomorrow.

- Cyrille


On November 12th, 2010, 10:46 p.m., Cyrille Berger wrote:

Review request for KOffice.
By Cyrille Berger.

Updated 2010-11-12 22:46:25

Descripti= on 

The attached patch fix bug:254264, that happen randomly in a=
ny koffice application when removing a view.

Testing <= /h1> 
In Krita, after removing a view, the window is set a minimum=
 size, but this behavior also happen without the patch (even if difficult t=
o reproduce, but sometime, when I don't get the crash I can see the min=
imum size bug)

Diffs=

  • trunk/koffice/libs/main/KoMainWindow.cpp (= 1196098)

View Diff
--===============4363627048942142823==-- --===============1922550625== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1922550625==--