'Re: Review Request: Fix for bug 255993'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix for bug 255993
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-11-10 22:32:45
Message-ID: 20101110223245.19089.76994 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5817/#review8658
-----------------------------------------------------------

Ship it!

good catch!

- Thomas

On 2010-11-10 15:08:26, Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5817/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 15:08:26)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Fix crash happening when loading the document in https://bugs.kde.org/show_bug.cgi?id=255993
> 
> The problem is that the rdfData is not set when loading the header.
> 
> Set the rdf data when loading the header and also make test that if rdfData is there, if not return.
> 
> 
> This addresses bug 255993.
>     https://bugs.kde.org/show_bug.cgi?id=255993
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/kword/part/KWOdfLoader.cpp 1193228 
>   trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1193228 
> 
> Diff: http://svn.reviewboard.kde.org/r/5817/diff
> 
> 
> Testing
> -------
> 
> The crash is fixed
> 
> 
> Thanks,
> 
> Thorsten
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5817/">http://svn.reviewboard.kde.org/r/5817/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good catch!</pre>  <br \
/>

<p>- Thomas</p>

<br />
<p>On November 10th, 2010, 3:08 p.m., Thorsten Zachmann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Thorsten Zachmann.</div>

<p style="color: grey;"><i>Updated 2010-11-10 15:08:26</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix crash happening when loading the document in \
https://bugs.kde.org/show_bug.cgi?id=255993

The problem is that the rdfData is not set when loading the header.

Set the rdf data when loading the header and also make test that if rdfData is there, \
if not return.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The crash is fixed</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=255993">255993</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/kword/part/KWOdfLoader.cpp <span style="color: \
grey">(1193228)</span></li>

 <li>trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(1193228)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5817/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 