[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Optimize KoXmlReader
From:       "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date:       2010-10-28 17:37:27
Message-ID: 20101028173727.3363.7026 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5693/#review8413
-----------------------------------------------------------

Ship it!


No further complaints from me :)

- Marijn


On 2010-10-28 05:59:52, Thorsten Zachmann wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5693/
> -----------------------------------------------------------
> =

> (Updated 2010-10-28 05:59:52)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> Use the tag instead of the namespace in the hash function. This reduces t=
he number of compares quite a bit as there the data is better distributed.
> =

> Only create prefix and localName when needed.
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/libs/odf/KoXmlReader.cpp 1188346 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5693/diff
> =

> =

> Testing
> -------
> =

> Test work as before. Documents load without problems.
> =

> =

> Thanks,
> =

> Thorsten
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5693/">http://svn.reviewboard.kde.org/r/5693/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No further complaints \
from me :)</pre>  <br />







<p>- Marijn</p>


<br />
<p>On October 28th, 2010, 5:59 a.m., Thorsten Zachmann wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Thorsten Zachmann.</div>


<p style="color: grey;"><i>Updated 2010-10-28 05:59:52</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use the tag instead of the namespace in the hash function. This reduces \
the number of compares quite a bit as there the data is better distributed.

Only create prefix and localName when needed.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Test work as before. Documents load without problems.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/odf/KoXmlReader.cpp <span style="color: \
grey">(1188346)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5693/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic