From koffice-devel Thu Oct 28 17:37:27 2010 From: "Marijn Kruisselbrink" Date: Thu, 28 Oct 2010 17:37:27 +0000 To: koffice-devel Subject: Re: Review Request: Optimize KoXmlReader Message-Id: <20101028173727.3363.7026 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128828752102806 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1692030099==" --===============1692030099== Content-Type: multipart/alternative; boundary="===============9057848482851961328==" --===============9057848482851961328== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5693/#review8413 ----------------------------------------------------------- Ship it! No further complaints from me :) - Marijn On 2010-10-28 05:59:52, Thorsten Zachmann wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5693/ > ----------------------------------------------------------- > = > (Updated 2010-10-28 05:59:52) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Use the tag instead of the namespace in the hash function. This reduces t= he number of compares quite a bit as there the data is better distributed. > = > Only create prefix and localName when needed. > = > = > Diffs > ----- > = > trunk/koffice/libs/odf/KoXmlReader.cpp 1188346 = > = > Diff: http://svn.reviewboard.kde.org/r/5693/diff > = > = > Testing > ------- > = > Test work as before. Documents load without problems. > = > = > Thanks, > = > Thorsten > = > --===============9057848482851961328== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5693/

Ship it!

No further=
 complaints from me :)

- Marijn


On October 28th, 2010, 5:59 a.m., Thorsten Zachmann wrote:

Review request for KOffice.
By Thorsten Zachmann.

Updated 2010-10-28 05:59:52

Descripti= on 

Use the tag instead of the namespace in the hash function. T=
his reduces the number of compares quite a bit as there the data is better =
distributed.

Only create prefix and localName when needed.

Testing <= /h1> 
Test work as before. Documents load without problems.

Diffs=

  • trunk/koffice/libs/odf/KoXmlReader.cpp (11= 88346)

View Diff
--===============9057848482851961328==-- --===============1692030099== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1692030099==--