[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Handling color of the bullets in msooxml filters
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2010-10-20 10:42:26
Message-ID: 20101020104226.11690.68183 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5667/#review8259
-----------------------------------------------------------
Ship it!
Nice patch. After committing it, I suggest that you also add calls to this=
check from the various lvl<1-9>pPr tags. I guess that bullet colors are e=
specially important in lists.
trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h
<http://svn.reviewboard.kde.org/r/5667/#comment8543>
Especially for the bullet colors, it would not hurt at all if the lvl<=
x>pPr was supported as well.
- Inge
On 2010-10-20 08:12:46, nandita suri wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5667/
> -----------------------------------------------------------
> =
> (Updated 2010-10-20 08:12:46)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> Color of the bullet is not handled in msooxml filters.
> Handled buClr and two of its child elements srgbClr and schemeClr.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h 118=
7692 =
> trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h =
1187692 =
> trunk/koffice/filters/libmsooxml/MsooXmlUtils.h 1187692 =
> trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp 1187692 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5667/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> nandita
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5667/">http://svn.reviewboard.kde.org/r/5667/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice patch. After \
committing it, I suggest that you also add calls to this check from the various \
lvl<1-9>pPr tags. I guess that bullet colors are especially important in \
lists.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5667/diff/1/?file=39761#file39761line4475" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KoFilter::ConversionStatus MSOOXML_CURRENT_CLASS::read_buChar()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">4475</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> - lvl1pPr ( §21.1.2.4.13)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Especially \
for the bullet colors, it would not hurt at all if the lvl<x>pPr was supported \
as well.</pre> </div>
<br />
<p>- Inge</p>
<br />
<p>On October 20th, 2010, 8:12 a.m., nandita suri wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By nandita suri.</div>
<p style="color: grey;"><i>Updated 2010-10-20 08:12:46</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Color of the bullet is not handled in msooxml filters. Handled buClr and \
two of its child elements srgbClr and schemeClr.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h <span \
style="color: grey">(1187692)</span></li>
<li>trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h <span \
style="color: grey">(1187692)</span></li>
<li>trunk/koffice/filters/libmsooxml/MsooXmlUtils.h <span style="color: \
grey">(1187692)</span></li>
<li>trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp <span style="color: \
grey">(1187692)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5667/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic