--===============0207597165== Content-Type: multipart/alternative; boundary="===============1602233432535789602==" --===============1602233432535789602== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5667/#review8259 ----------------------------------------------------------- Ship it! Nice patch. After committing it, I suggest that you also add calls to this= check from the various lvl<1-9>pPr tags. I guess that bullet colors are e= specially important in lists. trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h Especially for the bullet colors, it would not hurt at all if the lvl<= x>pPr was supported as well. - Inge On 2010-10-20 08:12:46, nandita suri wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5667/ > ----------------------------------------------------------- > = > (Updated 2010-10-20 08:12:46) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Color of the bullet is not handled in msooxml filters. > Handled buClr and two of its child elements srgbClr and schemeClr. > = > = > Diffs > ----- > = > trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h 118= 7692 = > trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h = 1187692 = > trunk/koffice/filters/libmsooxml/MsooXmlUtils.h 1187692 = > trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp 1187692 = > = > Diff: http://svn.reviewboard.kde.org/r/5667/diff > = > = > Testing > ------- > = > = > Thanks, > = > nandita > = > --===============1602233432535789602== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5667/

Ship it!

Nice patch=
.  After committing it, I suggest that you also add calls to this check fro=
m the various lvl<1-9>pPr tags.  I guess that bullet colors are espec=
ially important in lists.

= =

trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingML= Impl.h (Diff revision 1)
KoFilter::ConversionStatus MSOOXML_CURRENT_CLASS::read_buChar()
		4475	- lvl1pPr (=C2=A721.1.2.4.= 13)

Especially for the bullet colors, it would not hurt at all if  the l=
vl<x>pPr was supported as well.

- Inge

On October 20th, 2010, 8:12 a.m., nandita suri wrote:

Review request for KOffice.

By nandita suri.

Updated 2010-10-20 08:12:46

Descripti= on

Color of the bullet is not handled in msooxml filters.
Handled buClr and two of its child elements srgbClr and schemeClr.

Diffs=

trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h (1187692)
trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLMethods.h= (1187692)
trunk/koffice/filters/libmsooxml/MsooXmlUtils.h (1187692)
trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp (1187692)

--===============1602233432535789602==-- --===============0207597165== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0207597165==--