[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Port KoDocumentInfoDlg to akonadi
From: "Adam Pigg" <adam () piggz ! co ! uk>
Date: 2010-10-19 17:20:57
Message-ID: 20101019172057.8846.20099 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-19 12:34:54, Thomas Zander wrote:
> > Awesome to have this done, very nice work :)
> >
> > I personally would be fine with this landing in trunk now, maybe you can ask \
> > Cyrille (our release manager) for permission.
>
> Cyrille Berger wrote:
> s/manager/coordinator/ since it seems to rely on KDE 4.5, I would wait until next \
> release (unless there is something broken in the current approach, apart from the \
> unavailability on maemo, but that is not problem since they release from essen).
thx for the vote of confidence thomas, but i agree this can wait until after the \
release due to a) it requiring updated kdelibs and b) it not being tested yet due to \
issues with nepomuk
> On 2010-10-19 12:34:54, Thomas Zander wrote:
> > trunk/koffice/libs/main/KoDocumentInfoDlg.cpp, line 42
> > <http://svn.reviewboard.kde.org/r/5655/diff/1/?file=39735#file39735line42>
> >
> > should this be removed then?
no, only stdaddresslist is deprecated, the addressee is what is returned by the \
contactsearchjob
> On 2010-10-19 12:34:54, Thomas Zander wrote:
> > trunk/koffice/libs/main/KoDocumentInfoDlg.cpp, line 418
> > <http://svn.reviewboard.kde.org/r/5655/diff/1/?file=39735#file39735line418>
> >
> > Same here; lots of spaces on this line should be removed.
ok
> On 2010-10-19 12:34:54, Thomas Zander wrote:
> > trunk/koffice/libs/main/KoDocumentInfoDlg.cpp, line 425
> > <http://svn.reviewboard.kde.org/r/5655/diff/1/?file=39735#file39735line425>
> >
> > After casting maybe you can check the pointer if its still valid.
ok
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5655/#review8232
-----------------------------------------------------------
On 2010-10-19 17:15:04, Adam Pigg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5655/
> -----------------------------------------------------------
>
> (Updated 2010-10-19 17:15:04)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> Port KoDocumentInfoDlg to akonadi becuase KABC::StdAddressBook is deprecated (and \
> not shipped on maemo). Akonadi devs suggested this approach.
> I probably also should change the cursor to a 'busy' while the search is occuring, \
> though it should be fast.
> Still to come will be replacing other places where StdAddressBook is used.
>
> This is almost certainly for after the next release, and may need some #if magic to \
> work with older kdelibs, unless the minimum version is increased to ~4.5 i guess.
>
> Diffs
> -----
>
> trunk/koffice/libs/main/CMakeLists.txt 1186295
> trunk/koffice/libs/main/KoDocumentInfoDlg.h 1186295
> trunk/koffice/libs/main/KoDocumentInfoDlg.cpp 1186295
>
> Diff: http://svn.reviewboard.kde.org/r/5655/diff
>
>
> Testing
> -------
>
> Not a lot! Actually, it doesnt work here at the moment. The info from the first \
> function works fine, but no results are returned by the job. Speaking in #kontact, \
> this seems to be a regression with current trunk, and the code _should_ work ;)
>
> Thanks,
>
> Adam
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5655/">http://svn.reviewboard.kde.org/r/5655/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 19th, 2010, 12:34 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Awesome to have this done, very nice work :)
I personally would be fine with this landing in trunk now, maybe you can ask Cyrille \
(our release manager) for permission.</pre> </blockquote>
<p>On October 19th, 2010, 1:02 p.m., <b>Cyrille Berger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">s/manager/coordinator/ \
since it seems to rely on KDE 4.5, I would wait until next release (unless there is \
something broken in the current approach, apart from the unavailability on maemo, but \
that is not problem since they release from essen).</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thx for the vote of \
confidence thomas, but i agree this can wait until after the release due to a) it \
requiring updated kdelibs and b) it not being tested yet due to issues with \
nepomuk</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 19th, 2010, 12:34 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5655/diff/1/?file=39735#file39735line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/main/KoDocumentInfoDlg.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">42</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
<kabc/addressee.h></span></pre></td> <th bgcolor="#f0f0f0" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">42</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
<kabc/addressee.h></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should this be removed \
then?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no, only \
stdaddresslist is deprecated, the addressee is what is returned by the \
contactsearchjob</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 19th, 2010, 12:34 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5655/diff/1/?file=39735#file39735line418" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/main/KoDocumentInfoDlg.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KoDocumentInfoDlg::slotDeleteAuthorInfo()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">415</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">connect</span><span class="p">(</span> <span class="n">job</span><span \
class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span> <span \
class="n">result</span><span class="p">(</span> <span class="n">KJob</span><span \
class="o">*</span> <span class="p">)</span> <span class="p">),</span> <span \
class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span> <span class="n">searchContactResult</span><span class="p">(</span> \
<span class="n">KJob</span><span class="o">*</span> <span class="p">)</span> <span \
class="p">)</span> <span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same here; lots of \
spaces on this line should be removed.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok</pre> \
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 19th, 2010, 12:34 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5655/diff/1/?file=39735#file39735line425" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/main/KoDocumentInfoDlg.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KoDocumentInfoDlg::slotDeleteAuthorInfo()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">422</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Akonadi</span><span class="o">::</span><span \
class="n">ContactSearchJob</span> <span class="o">*</span><span \
class="n">searchJob</span> <span class="o">=</span> <span \
class="n">qobject_cast</span><span class="o"><</span><span \
class="n">Akonadi</span><span class="o">::</span><span \
class="n">ContactSearchJob</span><span class="o">*></span><span class="p">(</span> \
<span class="n">job</span> <span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After casting maybe you \
can check the pointer if its still valid.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok</pre> \
<br />
<p>- Adam</p>
<br />
<p>On October 19th, 2010, 5:15 p.m., Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated 2010-10-19 17:15:04</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port KoDocumentInfoDlg to akonadi becuase KABC::StdAddressBook is \
deprecated (and not shipped on maemo). Akonadi devs suggested this approach.
I probably also should change the cursor to a 'busy' while the search is \
occuring, though it should be fast.
Still to come will be replacing other places where StdAddressBook is used.
This is almost certainly for after the next release, and may need some #if magic to \
work with older kdelibs, unless the minimum version is increased to ~4.5 i \
guess.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Not a lot! Actually, it doesnt work here at the moment. The info from \
the first function works fine, but no results are returned by the job. Speaking in \
#kontact, this seems to be a regression with current trunk, and the code _should_ \
work ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/main/CMakeLists.txt <span style="color: \
grey">(1186295)</span></li>
<li>trunk/koffice/libs/main/KoDocumentInfoDlg.h <span style="color: \
grey">(1186295)</span></li>
<li>trunk/koffice/libs/main/KoDocumentInfoDlg.cpp <span style="color: \
grey">(1186295)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5655/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic