'Re: Review Request: Port KoDocumentInfoDlg to akonadi'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Port KoDocumentInfoDlg to akonadi
From:       "Adam Pigg" <adam () piggz ! co ! uk>
Date:       2010-10-19 17:15:05
Message-ID: 20101019171505.8237.13038 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5655/
-----------------------------------------------------------

(Updated 2010-10-19 17:15:04.767438)

Review request for KOffice.

Changes
-------

Changes as per comments

Summary
-------

Port KoDocumentInfoDlg to akonadi becuase KABC::StdAddressBook is deprecate=
d (and not shipped on maemo).  Akonadi devs suggested this approach.

I probably also should change the cursor to a 'busy' while the search is oc=
curing, though it should be fast.

Still to come will be replacing other places where StdAddressBook is used.

This is almost certainly for after the next release, and may need some #if =
magic to work with older kdelibs, unless the minimum version is increased t=
o ~4.5 i guess.

Diffs (updated)
-----

  trunk/koffice/libs/main/CMakeLists.txt 1186295 =

  trunk/koffice/libs/main/KoDocumentInfoDlg.h 1186295 =

  trunk/koffice/libs/main/KoDocumentInfoDlg.cpp 1186295 =

Diff: http://svn.reviewboard.kde.org/r/5655/diff

Testing
-------

Not a lot!  Actually, it doesnt work here at the moment.  The info from the=
 first function works fine, but no results are returned by the job.  Speaki=
ng in #kontact, this seems to be a regression with current trunk, and the c=
ode _should_ work ;)

Thanks,

Adam

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5655/">http://svn.reviewboard.kde.org/r/5655/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Adam Pigg.</div>

<p style="color: grey;"><i>Updated 2010-10-19 17:15:04.767438</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changes as per comments</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port KoDocumentInfoDlg to akonadi becuase KABC::StdAddressBook is \
deprecated (and not shipped on maemo).  Akonadi devs suggested this approach.

I probably also should change the cursor to a &#39;busy&#39; while the search is \
occuring, though it should be fast.

Still to come will be replacing other places where StdAddressBook is used.

This is almost certainly for after the next release, and may need some #if magic to \
work with older kdelibs, unless the minimum version is increased to ~4.5 i \
guess.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Not a lot!  Actually, it doesnt work here at the moment.  The info from \
the first function works fine, but no results are returned by the job.  Speaking in \
#kontact, this seems to be a regression with current trunk, and the code _should_ \
work ;)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/main/CMakeLists.txt <span style="color: \
grey">(1186295)</span></li>

 <li>trunk/koffice/libs/main/KoDocumentInfoDlg.h <span style="color: \
grey">(1186295)</span></li>

 <li>trunk/koffice/libs/main/KoDocumentInfoDlg.cpp <span style="color: \
grey">(1186295)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5655/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 