[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: make building of some plugins optionally
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-09-21 15:53:24
Message-ID: 20100921155324.23790.86869 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-21 08:33:32, Thomas Zander wrote:
> > Why would the variables plugin be optional while the text one is not?
> > I would prefer it to not be optional as this would imply that the cmake option is \
> > -DBUILD_variables=true. Which is not really a helpful (i.e. readable) command \
> > line option.
>
> Johannes Simon wrote:
> Yes, the meaning of the CMake option would be hard to guess. So why not give it a \
> slightly more telling name like variables-plugin? Though I'm not sure how that's \
> technically possible in CMake, but renaming the directory would be one option.
Renaming the dir sounds like the wrong solution, though. Certainly an overkill \
solution.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5382/#review7704
-----------------------------------------------------------
On 2010-09-19 09:27:20, Adam C. wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5382/
> -----------------------------------------------------------
>
> (Updated 2010-09-19 09:27:20)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> the building of the plugins variables, chartshape, pictureshape, videoshape and \
> treeshape is not mandatory for every application, so it should be possible to \
> disable them.
>
> Diffs
> -----
>
> /trunk/koffice/plugins/CMakeLists.txt 1176756
>
> Diff: http://svn.reviewboard.kde.org/r/5382/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5382/">http://svn.reviewboard.kde.org/r/5382/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 21st, 2010, 8:33 a.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Why would the variables plugin be optional while the text one is not? I \
would prefer it to not be optional as this would imply that the cmake option is \
-DBUILD_variables=true. Which is not really a helpful (i.e. readable) command line \
option.</pre> </blockquote>
<p>On September 21st, 2010, 3:12 p.m., <b>Johannes Simon</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, the meaning of the \
CMake option would be hard to guess. So why not give it a slightly more telling name \
like variables-plugin? Though I'm not sure how that's technically possible in \
CMake, but renaming the directory would be one option.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Renaming the dir sounds \
like the wrong solution, though. Certainly an overkill solution.</pre> <br />
<p>- Thomas</p>
<br />
<p>On September 19th, 2010, 9:27 a.m., Adam C. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Adam C..</div>
<p style="color: grey;"><i>Updated 2010-09-19 09:27:20</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the building of the plugins variables, chartshape, pictureshape, \
videoshape and treeshape is not mandatory for every application, so it should be \
possible to disable them.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/plugins/CMakeLists.txt <span style="color: \
grey">(1176756)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5382/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic