--===============0940895011== Content-Type: multipart/alternative; boundary="===============7255552184628368859==" --===============7255552184628368859== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-09-21 08:33:32, Thomas Zander wrote: > > Why would the variables plugin be optional while the text one is not? > > I would prefer it to not be optional as this would imply that the cmake= option is -DBUILD_variables=3Dtrue. Which is not really a helpful (i.e. re= adable) command line option. > = > Johannes Simon wrote: > Yes, the meaning of the CMake option would be hard to guess. So why n= ot give it a slightly more telling name like variables-plugin? Though I'm n= ot sure how that's technically possible in CMake, but renaming the director= y would be one option. Renaming the dir sounds like the wrong solution, though. Certainly an overk= ill solution. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5382/#review7704 ----------------------------------------------------------- On 2010-09-19 09:27:20, Adam C. wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5382/ > ----------------------------------------------------------- > = > (Updated 2010-09-19 09:27:20) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > the building of the plugins variables, chartshape, pictureshape, videosha= pe and treeshape is not mandatory for every application, so it should be po= ssible to disable them. > = > = > Diffs > ----- > = > /trunk/koffice/plugins/CMakeLists.txt 1176756 = > = > Diff: http://svn.reviewboard.kde.org/r/5382/diff > = > = > Testing > ------- > = > = > Thanks, > = > Adam > = > --===============7255552184628368859== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5382/

On September 21st, 2010, 8:33 a.m., Thomas = Zander wrote:

Why would=
 the variables plugin be optional while the text one is not?
I would prefer it to not be optional as this would imply that the cmake opt=
ion is -DBUILD_variables=3Dtrue. Which is not really a helpful (i.e. readab=
le) command line option.

On September 21st, 2010, 3:12 p.m., Johannes Simon wrote:

Yes, the =
meaning of the CMake option would be hard to guess. So why not give it a sl=
ightly more telling name like variables-plugin? Though I'm not sure how=
 that's technically possible in CMake, but renaming the directory would=
 be one option.
Renaming th=
e dir sounds like the wrong solution, though. Certainly an overkill solutio=
n.

- Thomas


On September 19th, 2010, 9:27 a.m., Adam C. wrote:

Review request for KOffice.
By Adam C..

Updated 2010-09-19 09:27:20

Descripti= on 

the building of the plugins variables, chartshape, picturesh=
ape, videoshape and treeshape is not mandatory for every application, so it=
 should be possible to disable them.

Diffs=

  • /trunk/koffice/plugins/CMakeLists.txt (117= 6756)

View Diff
--===============7255552184628368859==-- --===============0940895011== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0940895011==--