[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: PPT filter: Improved creation of drawing-page
From: "Matus Uzak" <matus.uzak () ixonos ! com>
Date: 2010-09-20 12:11:00
Message-ID: 20100920121100.2823.26977 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5297/
-----------------------------------------------------------
(Updated 2010-09-20 12:10:59.099976)
Review request for KOffice.
Changes
-------
* Added a few comments.
* Setting the currentMaster pointer to NULL each time we stop using it. We should \
avoid using global pointers to access PPT specific information in DrawClient \
functions.
Summary (updated)
-------
1. Let's create a drawing-page style for each main master slide.
2. Check what MUST be reused from style of the corresponding main master slide when \
creating a drawing-page style for a presentation slide. 3. Check what MUST be reused \
from style of the corresponding notes master slide when creating a drawing-page style \
for a notes slide.
This addresses bug 247757.
https://bugs.kde.org/show_bug.cgi?id=247757
Diffs (updated)
-----
trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.h 1177327
trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.cpp 1177327
trunk/koffice/filters/kpresenter/powerpoint/pptstyle.h 1177327
trunk/koffice/filters/kpresenter/powerpoint/pptstyle.cpp 1177327
Diff: http://svn.reviewboard.kde.org/r/5297/diff
Testing
-------
Can't get the background color displayed in both kpresenter and ooimpress. \
Investigation required for kpresenter. The drawing-page style of the \
<presentation:notes> element in <master-page> element is the problem of ooimpress. \
Their input filter is not using a drawing-page style there, which I think is not \
correct.
Thanks,
Matus
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5297/">http://svn.reviewboard.kde.org/r/5297/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Matus Uzak.</div>
<p style="color: grey;"><i>Updated 2010-09-20 12:10:59.099976</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Added a few comments.
* Setting the currentMaster pointer to NULL each time we stop using it. We should \
avoid using global pointers to access PPT specific information in DrawClient \
functions. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Let's create a drawing-page style for each main master slide. 2. \
Check what MUST be reused from style of the corresponding main master slide when \
creating a drawing-page style for a presentation slide. 3. Check what MUST be reused \
from style of the corresponding notes master slide when creating a drawing-page style \
for a notes slide.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Can't get the background color displayed in both kpresenter and \
ooimpress. Investigation required for kpresenter. The drawing-page style of the \
<presentation:notes> element in <master-page> element is the problem of \
ooimpress. Their input filter is not using a drawing-page style there, which I think \
is not correct. </pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=247757">247757</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.h <span style="color: \
grey">(1177327)</span></li>
<li>trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.cpp <span style="color: \
grey">(1177327)</span></li>
<li>trunk/koffice/filters/kpresenter/powerpoint/pptstyle.h <span style="color: \
grey">(1177327)</span></li>
<li>trunk/koffice/filters/kpresenter/powerpoint/pptstyle.cpp <span style="color: \
grey">(1177327)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5297/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic