--===============0875745098== Content-Type: multipart/alternative; boundary="===============4002480200496053865==" --===============4002480200496053865== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5297/ ----------------------------------------------------------- (Updated 2010-09-20 12:10:59.099976) Review request for KOffice. Changes ------- * Added a few comments. = * Setting the currentMaster pointer to NULL each time we stop using it. We= should avoid using global pointers to access PPT specific information in D= rawClient functions. = Summary (updated) ------- 1. Let's create a drawing-page style for each main master slide. 2. Check what MUST be reused from style of the corresponding main master sl= ide when creating a drawing-page style for a presentation slide. 3. Check what MUST be reused from style of the corresponding notes master s= lide when creating a drawing-page style for a notes slide. This addresses bug 247757. https://bugs.kde.org/show_bug.cgi?id=3D247757 Diffs (updated) ----- trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.h 1177327 = trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.cpp 1177327 = trunk/koffice/filters/kpresenter/powerpoint/pptstyle.h 1177327 = trunk/koffice/filters/kpresenter/powerpoint/pptstyle.cpp 1177327 = Diff: http://svn.reviewboard.kde.org/r/5297/diff Testing ------- Can't get the background color displayed in both kpresenter and ooimpress. = Investigation required for kpresenter. = The drawing-page style of the element in = element is the problem of ooimpress. Their input filter is not using a dr= awing-page style there, which I think is not correct. = Thanks, Matus --===============4002480200496053865== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5297/

Review request for KOffice.
By Matus Uzak.

Updated 2010-09-20 12:10:59.099976

Changes 
* Added a few comments. =

* Setting the currentMaster pointer to NULL each time we stop using it.  We=
 should avoid using global pointers to access PPT specific information in D=
rawClient functions.

Descripti= on (updated)

1. Let's create a drawing-page style for each main maste=
r slide.
2. Check what MUST be reused from style of the corresponding main master sl=
ide when creating a drawing-page style for a presentation slide.
3. Check what MUST be reused from style of the corresponding notes master s=
lide when creating a drawing-page style for a notes slide.

Testing <= /h1> 
Can't get the background color displayed in both kpresen=
ter and ooimpress. Investigation required for kpresenter.  =

The drawing-page style of the <presentation:notes> element in <mas=
ter-page> element is the problem of ooimpress.  Their input filter is no=
t using a drawing-page style there, which I think is not correct.
Bugs: 247757

Diffs= (updated)

  • trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.h (1177327)
  • trunk/koffice/filters/kpresenter/powerpoint/PptToOdp.cpp (1177327)
  • trunk/koffice/filters/kpresenter/powerpoint/pptstyle.h (1177327)
  • trunk/koffice/filters/kpresenter/powerpoint/pptstyle.cpp (1177327)

View Diff
--===============4002480200496053865==-- --===============0875745098== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0875745098==--