[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Set Qt 4.6.3 as minimum version
From:       "Adam C." <nospam () xibo ! at>
Date:       2010-09-19 12:39:50
Message-ID: op.vi95goj12qq4ze () damdam-laptop
[Download RAW message or body]

reviewboard is down, so sending on list.

I don't like, that krita will die. For some user it is working, not  
everybody needs a tablet.
I know, that tablet users are our main goal, but why prevent the use for  
others? Just a warning would be enough.

On Sun, 19 Sep 2010 14:05:17 +0200, Boudewijn Rempt <boud@valdyas.org>  
wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5356/#review7684
> -----------------------------------------------------------
>
>
> I'd prefer a runtime check -- something like this:
>
> diff --git a/krita/ui/kis_doc2.cc b/krita/ui/kis_doc2.cc
> index 128827f..37ab445 100644
> --- a/krita/ui/kis_doc2.cc
> +++ b/krita/ui/kis_doc2.cc
> @@ -139,6 +139,8 @@ public:
>      KisKraLoader* kraLoader;
>      KisKraSaver* kraSaver;
> +    QString error;
> +
>  };
> @@ -437,26 +439,32 @@ void KisDoc2::showStartUpWidget(KoMainWindow*  
> parent, bool alwaysShow)
>      // print error if the lcms engine is not available
>      if (!KoColorSpaceEngineRegistry::instance()->contains("icc")) {
>          // need to wait 1 event since exiting here would not work.
> +        m_d->error = i18n("The KOffice LittleCMS color management  
> plugin is not installed. Krita will quit now.");
>          QTimer::singleShot(0, this, SLOT(showErrorAndDie()));
>      }
> -    else {
> -        KoDocument::showStartUpWidget(parent, alwaysShow);
> -        KisConfig cfg;
> -        if (cfg.firstRun()) {
> -            QString fname =  
> KisFactory2::componentData().dirs()->findResource("kis_images",  
> "krita_first_start.kra");
> -            if (!fname.isEmpty()) {
> -                openUrl(fname);
> -            }
> -            cfg.setFirstRun(false);
> +
> +    QStringList qtversion = QString(qVersion()).split('.');
> +    if (qtversion[0] == "4" && qtversion[1] <= "6" &&  
> qtversion[3].toInt() < 3) {
> +        m_d->error = i18n("Krita needs at least Qt 4.6.3 to work  
> correctly. Your Qt version is %1.", qVersion());
> +        QTimer::singleShot(0, this, SLOT(showErrorAndDie()));
> +    }
> +
> +    KoDocument::showStartUpWidget(parent, alwaysShow);
> +    KisConfig cfg;
> +    if (cfg.firstRun()) {
> +        QString fname =  
> KisFactory2::componentData().dirs()->findResource("kis_images",  
> "krita_first_start.kra");
> +        if (!fname.isEmpty()) {
> +            openUrl(fname);
>          }
> +        cfg.setFirstRun(false);
>      }
>  }
> void KisDoc2::showErrorAndDie()
>  {
>      KMessageBox::error(widget(),
> -                       i18n("The KOffice LittleCMS color management  
> plugin is not installed. Krita will quit now."),
> -                       i18n("Installation Error"));
> +                       m_d->error,
> +                       i18n("Installation error"));
>      QCoreApplication::exit(10);
>  }
> diff --git a/libs/flake/KoCanvasControllerWidget.cpp  
> b/libs/flake/KoCanvasControllerWidget.cpp
> index 2a4b5d7..13eab93 100644
> --- a/libs/flake/KoCanvasControllerWidget.cpp
> +++ b/libs/flake/KoCanvasControllerWidget.cpp
> @@ -398,7 +398,7 @@ void KoCanvasControllerWidget::ensureVisible(KoShape  
> *shape)
> void KoCanvasControllerWidget::ensureVisible(const QRectF &rect, bool  
> smooth)
>  {
> -    QRect currentVisible(qMax(0, -canvasOffsetX()), qMax(0,  
> -canvasOffsetY()), visibleWidth(), visibleHeight());
> +    QRect currentVisible(-canvasOffsetX(), -canvasOffsetY(),  
> visibleWidth(), visibleHeight());
>     QRect viewRect = rect.toRect();
>      viewRect.translate(d->canvas->documentOrigin());
>
> - Boudewijn
>
>
> On 2010-09-15 02:43:37, Sven Langkamp wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://svn.reviewboard.kde.org/r/5356/
>> -----------------------------------------------------------
>>
>> (Updated 2010-09-15 02:43:37)
>>
>>
>> Review request for KOffice.
>>
>>
>> Summary
>> -------
>>
>> Patch set Qt 4.6.3 as minimum version. Previous version of Qt have a  
>> problem with the wacom tablet driver which leads to missing pressure  
>> support in Krita. The new minimum version will make sure that all user  
>> won't have that problem.
>>
>>
>> Diffs
>> -----
>>
>>   /trunk/koffice/CMakeLists.txt 1173537
>>
>> Diff: http://svn.reviewboard.kde.org/r/5356/diff
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Sven
>>
>>
>


-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]