[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: fix scaling of group
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-09-06 15:15:33
Message-ID: 20100906151533.4484.71275 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-05 05:48:58, Thorsten Zachmann wrote:
> > The patch fixes the problem of the selection also taking into account t=
he wrongly KoGroupShape as it no longer takes the wrong size of the group i=
nto account. However the wrong size of the group is still a problem. E.g. i=
t is possible to select the shapes by selecting the group outside of the sp=
ace where it should be selectable.
> > =
> > I'm not sure yet how to best fix that. Maybe you have an idea and we ca=
n fix that once and for all.
The selection (KoSelection) should not have the KoGroupShape in its list of=
selected objects if I select one; see the selection strategies (and relate=
d unit test). I'm doing this from memory; but thats how I remember it.
If the group is not part of the selection then the resizing should not be a=
pplied to it, it should only be applied to its children. And that makes thi=
s fix not needed.
Maybe the way that 'downsize' is implemented in Krita is wrong?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5253/#review7409
-----------------------------------------------------------
On 2010-09-04 20:39:34, Adam C. wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5253/
> -----------------------------------------------------------
> =
> (Updated 2010-09-04 20:39:34)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> this patch fixes the following bug:
> - create a group of (path) shapes
> - select and downsize
> - deselect
> - select
> =
> now the selection has the same size, as if there was no downsizing.
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/libs/flake/KoSelection.cpp 1170431 =
> /trunk/koffice/libs/flake/tests/TestShapeContainer.h 1171564 =
> /trunk/koffice/libs/flake/tests/TestShapeContainer.cpp 1171564 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5253/diff
> =
> =
> Testing
> -------
> =
> tested in krita, looks good
> created testcase, also looks good
> =
> =
> Thanks,
> =
> Adam
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5253/">http://svn.reviewboard.kde.org/r/5253/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 5th, 2010, 5:48 a.m., <b>Thorsten \
Zachmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch fixes the problem of the selection also taking into account \
the wrongly KoGroupShape as it no longer takes the wrong size of the group into \
account. However the wrong size of the group is still a problem. E.g. it is possible \
to select the shapes by selecting the group outside of the space where it should be \
selectable.
I'm not sure yet how to best fix that. Maybe you have an idea and we can fix that \
once and for all.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The selection \
(KoSelection) should not have the KoGroupShape in its list of selected objects if I \
select one; see the selection strategies (and related unit test). I'm doing this \
from memory; but thats how I remember it. If the group is not part of the selection \
then the resizing should not be applied to it, it should only be applied to its \
children. And that makes this fix not needed.
Maybe the way that 'downsize' is implemented in Krita is wrong?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On September 4th, 2010, 8:39 p.m., Adam C. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Adam C..</div>
<p style="color: grey;"><i>Updated 2010-09-04 20:39:34</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this patch fixes the following bug:
- create a group of (path) shapes
- select and downsize
- deselect
- select
now the selection has the same size, as if there was no downsizing.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested in krita, looks good created testcase, also looks good</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/libs/flake/KoSelection.cpp <span style="color: \
grey">(1170431)</span></li>
<li>/trunk/koffice/libs/flake/tests/TestShapeContainer.h <span style="color: \
grey">(1171564)</span></li>
<li>/trunk/koffice/libs/flake/tests/TestShapeContainer.cpp <span style="color: \
grey">(1171564)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5253/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic