[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: fixes the saving functionality in freoffice.
From: "Mani Chandrasekar" <maninc () gmail ! com>
Date: 2010-09-02 7:02:58
Message-ID: 20100902070258.531.36359 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5235/#review7356
-----------------------------------------------------------
Ship it!
- Mani
On 2010-09-02 06:39:15, sugnan prabhu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5235/
> -----------------------------------------------------------
> =
> (Updated 2010-09-02 06:39:15)
> =
> =
> Review request for KOffice and Mani Chandrasekar.
> =
> =
> Summary
> -------
> =
> Patch for FreOffice, which removes document modified flag, which further =
fixes the problem that was causing due to it, like asking for save even whe=
n shortcuts are executed, and now shows the confirmation dialog even when a=
minor change is made in document like changing the position of image in od=
p document.
> Fixes the problem of closing document, ie when we reject the confirmation=
dialog which appears when we try to close the modified document and save t=
he document from the menu, which will close the document.
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/tools/f-office/MainWindow.h 1170791 =
> /trunk/koffice/tools/f-office/MainWindow.cpp 1170791 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5235/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> sugnan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5235/">http://svn.reviewboard.kde.org/r/5235/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Mani</p>
<br />
<p>On September 2nd, 2010, 6:39 a.m., sugnan prabhu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice and Mani Chandrasekar.</div>
<div>By sugnan prabhu.</div>
<p style="color: grey;"><i>Updated 2010-09-02 06:39:15</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch for FreOffice, which removes document modified flag, which further \
fixes the problem that was causing due to it, like asking for save even when \
shortcuts are executed, and now shows the confirmation dialog even when a minor \
change is made in document like changing the position of image in odp document. Fixes \
the problem of closing document, ie when we reject the confirmation dialog which \
appears when we try to close the modified document and save the document from the \
menu, which will close the document.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/tools/f-office/MainWindow.h <span style="color: \
grey">(1170791)</span></li>
<li>/trunk/koffice/tools/f-office/MainWindow.cpp <span style="color: \
grey">(1170791)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5235/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic