'Review Request: Applies the correct colors to the chart according to'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Applies the correct colors to the chart according to
From:       Björn_Breitmeyer <bjoern.breitmeyer () kdab ! com>
Date:       2010-08-24 14:13:31
Message-ID: 20100824141331.25733.60053 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5133/
-----------------------------------------------------------

Review request for KOffice, Johannes Simon and Sebastian Sauer.

Summary
-------

Applies the correct colors to the chart according to the theme selected by =
style tag. And implemented the primitive loading of fill-colors and

Diffs
-----

  trunk/koffice/filters/CMakeLists.txt 1165426 =

  trunk/koffice/filters/kspread/xlsx/ChartExport.h 1165426 =

  trunk/koffice/filters/kspread/xlsx/ChartExport.cpp 1165426 =

  trunk/koffice/filters/kspread/xlsx/Charting.h 1165426 =

  trunk/koffice/filters/kspread/xlsx/XlsxXmlChartReader.h 1165426 =

  trunk/koffice/filters/kspread/xlsx/XlsxXmlChartReader.cpp 1165426 =

  trunk/koffice/filters/kspread/xlsx/XlsxXmlDrawingReader.cpp 1165426 =

  trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h 11654=
26 =

  trunk/koffice/plugins/chartshape/Axis.cpp 1165426 =

Diff: http://reviewboard.kde.org/r/5133/diff

Testing
-------

Loaded several documents with colored charts and different styles.

Thanks,

Bj=C3=B6rn

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/5133/">http://reviewboard.kde.org/r/5133/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice, Johannes Simon and Sebastian Sauer.</div>
<div>By Björn Breitmeyer.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Applies the correct colors to the chart according to the theme selected \
by style tag. And implemented the primitive loading of fill-colors and </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Loaded several documents with colored charts and different styles.</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/filters/CMakeLists.txt <span style="color: \
grey">(1165426)</span></li>

 <li>trunk/koffice/filters/kspread/xlsx/ChartExport.h <span style="color: \
grey">(1165426)</span></li>

 <li>trunk/koffice/filters/kspread/xlsx/ChartExport.cpp <span style="color: \
grey">(1165426)</span></li>

 <li>trunk/koffice/filters/kspread/xlsx/Charting.h <span style="color: \
grey">(1165426)</span></li>

 <li>trunk/koffice/filters/kspread/xlsx/XlsxXmlChartReader.h <span style="color: \
grey">(1165426)</span></li>

 <li>trunk/koffice/filters/kspread/xlsx/XlsxXmlChartReader.cpp <span style="color: \
grey">(1165426)</span></li>

 <li>trunk/koffice/filters/kspread/xlsx/XlsxXmlDrawingReader.cpp <span style="color: \
grey">(1165426)</span></li>

 <li>trunk/koffice/filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h <span \
style="color: grey">(1165426)</span></li>

 <li>trunk/koffice/plugins/chartshape/Axis.cpp <span style="color: \
grey">(1165426)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/5133/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 