'Re: Review Request: FreOffice: Fixes a number of bugs and some UI'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: FreOffice: Fixes a number of bugs and some UI
From:       "Mani Chandrasekar" <maninc () gmail ! com>
Date:       2010-08-24 10:37:50
Message-ID: 20100824103750.10636.28709 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5088/#review7194
-----------------------------------------------------------

Ship it!

- Mani

On 2010-08-23 08:20:48, Gopalakrishna Bhat wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5088/
> -----------------------------------------------------------
> =

> (Updated 2010-08-23 08:20:48)
> =

> =

> Review request for KOffice and Mani Chandrasekar.
> =

> =

> Summary
> -------
> =

> This patch fixes the following bugs
> * Allows FreOffice to open DOCX, PPTX, XLSX also.
> * Not able to insert space in a new word document.
> * Horizontal center alignment was not saved though it was visible in the =
canvas.
> * Adds some Maemo 5 specific messages to the user while closing, last sli=
de reached etc.
> * Reordering of Cut, Copy, Paste actions according to the ones used in an=
y standard editor.
> * Spreadsheet uses the tool that is created by default than by explicitly=
 creating it.
> * Uppercase text problem for spreadsheets is also fixed.
> =

> =

> Diffs
> -----
> =

>   /trunk/koffice/tools/f-office/FoCellEditor.cpp 1166842 =

>   /trunk/koffice/tools/f-office/FoCellTool.cpp 1166842 =

>   /trunk/koffice/tools/f-office/FoCellToolFactory.h 1166842 =

>   /trunk/koffice/tools/f-office/FoCellToolFactory.cpp 1166842 =

>   /trunk/koffice/tools/f-office/FoExternalEditor.cpp 1166842 =

>   /trunk/koffice/tools/f-office/Main.cpp 1166842 =

>   /trunk/koffice/tools/f-office/MainWindow.h 1166842 =

>   /trunk/koffice/tools/f-office/MainWindow.cpp 1166842 =

>   /trunk/koffice/tools/f-office/MainWindow.ui 1166842 =

> =

> Diff: http://reviewboard.kde.org/r/5088/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Gopalakrishna
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/5088/">http://reviewboard.kde.org/r/5088/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<p>- Mani</p>

<br />
<p>On August 23rd, 2010, 8:20 a.m., Gopalakrishna Bhat wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice and Mani Chandrasekar.</div>
<div>By Gopalakrishna Bhat.</div>

<p style="color: grey;"><i>Updated 2010-08-23 08:20:48</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">This patch fixes the following bugs
* Allows FreOffice to open DOCX, PPTX, XLSX also.
* Not able to insert space in a new word document.
* Horizontal center alignment was not saved though it was visible in the canvas.
* Adds some Maemo 5 specific messages to the user while closing, last slide reached \
                etc.
* Reordering of Cut, Copy, Paste actions according to the ones used in any standard \
                editor.
* Spreadsheet uses the tool that is created by default than by explicitly creating \
                it.
* Uppercase text problem for spreadsheets is also fixed.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/tools/f-office/FoCellEditor.cpp <span style="color: \
grey">(1166842)</span></li>

 <li>/trunk/koffice/tools/f-office/FoCellTool.cpp <span style="color: \
grey">(1166842)</span></li>

 <li>/trunk/koffice/tools/f-office/FoCellToolFactory.h <span style="color: \
grey">(1166842)</span></li>

 <li>/trunk/koffice/tools/f-office/FoCellToolFactory.cpp <span style="color: \
grey">(1166842)</span></li>

 <li>/trunk/koffice/tools/f-office/FoExternalEditor.cpp <span style="color: \
grey">(1166842)</span></li>

 <li>/trunk/koffice/tools/f-office/Main.cpp <span style="color: \
grey">(1166842)</span></li>

 <li>/trunk/koffice/tools/f-office/MainWindow.h <span style="color: \
grey">(1166842)</span></li>

 <li>/trunk/koffice/tools/f-office/MainWindow.cpp <span style="color: \
grey">(1166842)</span></li>

 <li>/trunk/koffice/tools/f-office/MainWindow.ui <span style="color: \
grey">(1166842)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/5088/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 