[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/kword/part/frames
From:       "C. Boemann" <cbo () boemann ! dk>
Date:       2010-08-02 17:25:44
Message-ID: 201008021925.45118.cbo () boemann ! dk
[Download RAW message or body]

No particular reason. It was a small change that can easily be post reviewed, 
if people think it's wrong.

On Monday 02 August 2010 19:09:09 Thomas Zander wrote:
> Casper, maybe this mail didn't get through as the question was unanswered
> so far. Re-sending :)
> 
> On Thursday 22. July 2010 13.35.06 Thomas Zander wrote:
> > Is there a reason you stopped using reviewboard for commits that I think
> > there was a clear understanding we need reviewboard for ?
> > 
> > On Wednesday 21. July 2010 17.23.24 Casper Boemann wrote:
> > > SVN commit 1152612 by boemann:
> > > 
> > > Make layout of text not fail in certain situations in tables. The
> > > symptom was that every line of the text was laid out on individual
> > > lines.
> > > 
> > > This removes the rightIndent in the fitting process.
> > > 
> > > Try without this patch and see how it was even trying to do the wrong
> > > thing: Write some text and set some right indent, then add a anchored
> > > shape and you will see how it worked wrongly
> > > 
> > >  M  +0 -4      KWTextDocumentLayout.cpp
> > > 
> > > --- trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp
> > > #1152611:1152612 @@ -268,7 +268,6 @@
> > > 
> > >              void tryFit() {
> > >              
> > >                  const qreal leftIndent = m_state->x();
> > >                  const qreal width = m_state->width();
> > > 
> > > -                const qreal rightIndent =
> > > m_state->shape->size().width() - width - leftIndent; QRectF
> > > rect(leftIndent, m_state->y(), width, 1.);
> > > line.setLineWidth(rect.width());
> > > 
> > >                  if (rect.width() <= 0. || line.textLength() == 0) {
> > > 
> > > @@ -294,9 +293,6 @@
> > > 
> > >                              x += leftIndent;
> > >                              effectiveLineWidth -= leftIndent;
> > >                          
> > >                          }
> > > 
> > > -                        if (leftIndent + width > rect.right()) //
> > > limit moved the right edge, keep the indent. -
> > > effectiveLineWidth = rect.width() - rightIndent; -
> > > 
> > >                          line.setLineWidth(effectiveLineWidth);
> > >                          line.setPosition(QPointF(x, rect.y()));
> > >                      
> > >                      }
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]