'Re: Review Request: Dropcap should also affect following paragraph'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Dropcap should also affect following paragraph
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-07-15 17:19:19
Message-ID: 20100715171919.14064.52082 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On 2010-07-15 17:07:18, Thomas Zander wrote:
> > The drop caps feature is a paragraph property; if the drop caps is larg=
er than the paragraph it should make the next paragraph move down so it can=
 again start at the left of the document.
> > =

> > I verified that this is what scribus does too.

yeah you are right. i'll create a new patch

- Casper

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4652/#review6593
-----------------------------------------------------------

On 2010-07-15 16:44:01, Casper Boemann wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4652/
> -----------------------------------------------------------
> =

> (Updated 2010-07-15 16:44:01)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> A dropcap that spills down into the next paragraph should also affect the=
 lines in that paragraph.
> =

> This patch fixes that
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/plugins/textshape/Layout.cpp 1150217 =

>   trunk/koffice/plugins/textshape/tests/TestDocumentLayout.cpp 1149458 =

> =

> Diff: http://reviewboard.kde.org/r/4652/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Casper
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4652/">http://reviewboard.kde.org/r/4652/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 15th, 2010, 5:07 p.m., <b>Thomas \
Zander</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre>The drop caps feature is a paragraph property; \
if the drop caps is larger than the paragraph it should make the next paragraph move \
down so it can again start at the left of the document.

I verified that this is what scribus does too.</pre>
 </blockquote>

</blockquote>

<pre>yeah you are right. i&#39;ll create a new patch</pre>
<br />

<p>- Casper</p>

<br />
<p>On July 15th, 2010, 4:44 p.m., Casper Boemann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Casper Boemann.</div>

<p style="color: grey;"><i>Updated 2010-07-15 16:44:01</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">A dropcap that spills down into the next \
paragraph should also affect the lines in that paragraph.

This patch fixes that</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1150217)</span></li>

 <li>trunk/koffice/plugins/textshape/tests/TestDocumentLayout.cpp <span style="color: \
grey">(1149458)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4652/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 