'Re: Review Request: Add support for draw:image-opacity'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add support for draw:image-opacity
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2010-06-24 15:02:30
Message-ID: 20100624150230.7623.40405 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4449/#review6264
-----------------------------------------------------------

Ship it!

Looks good. Please commit.

trunk/koffice/plugins/pictureshape/PictureShape.h
<http://reviewboard.kde.org/r/4449/#comment5908>

    please remove unneeded spaces

- Thorsten

On 2010-06-24 13:25:44, Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4449/
> -----------------------------------------------------------
> 
> (Updated 2010-06-24 13:25:44)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Patch adds loading and saving of draw:image-opacity
> 
> 
> This addresses bug 239729.
>     https://bugs.kde.org/show_bug.cgi?id=239729
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/plugins/pictureshape/PictureShape.h 1141841 
>   trunk/koffice/plugins/pictureshape/PictureShape.cpp 1141841 
> 
> Diff: http://reviewboard.kde.org/r/4449/diff
> 
> 
> Testing
> -------
> 
> Tested with file from bug 239729.
> 
> 
> Thanks,
> 
> Sven
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4449/">http://reviewboard.kde.org/r/4449/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre>Looks good. Please commit.</pre>
 <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4449/diff/2/?file=29722#file29722line68" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/koffice/plugins/pictureshape/PictureShape.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">public:</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">68</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: \
break-word;"><span class="ew">    </span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">please remove unneeded spaces</pre>
</div>
<br />

<p>- Thorsten</p>

<br />
<p>On June 24th, 2010, 1:25 p.m., Sven Langkamp wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>

<p style="color: grey;"><i>Updated 2010-06-24 13:25:44</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Patch adds loading and saving of \
draw:image-opacity</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Tested with file from bug 239729.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=239729">239729</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/plugins/pictureshape/PictureShape.h <span style="color: \
grey">(1141841)</span></li>

 <li>trunk/koffice/plugins/pictureshape/PictureShape.cpp <span style="color: \
grey">(1141841)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4449/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 