[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add some basic API for text on shape
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2010-06-17 4:13:08
Message-ID: 20100617041308.30889.47758 () localhost
[Download RAW message or body]



> On 2010-06-16 20:42:04, Thomas Zander wrote:
> > This should really be in svn to allow others to build on top of it.  Having my \
> > patch be part of another review request is not really useful without using git. \
> > I'll commit tomorrow unless someone has really good reasons not to. (remember, \
> > there is no functionality change in any app just by adding these classes that \
> > nobody uses currently)
> 
> Boudewijn Rempt wrote:
> There is a really good reason for you not to commit your patch tomorrow: you will \
> cause merge problems for me. And since nobody uses your code anyway, there is no \
> hurry committing it either. Plus, I totally am able to already build on it, I don't \
> need you to commit for that. 
> And there is a really good reason for you not to commit your patch: you did not get \
> a ship it for it, but some rather strong objections.

I think I strongly made clear why I think it should not be committed. There are just \
to many problems I see which can not easily be solved. You asked in your last request \
on what needs to be changed. I gave an explanation but I don't see it implemented so \
it should not go in.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3988/#review6153
-----------------------------------------------------------


On 2010-05-17 21:42:20, Thomas Zander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3988/
> -----------------------------------------------------------
> 
> (Updated 2010-05-17 21:42:20)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> There are some options for doing 'text-on'shape'. I just looked at OpenOffice what \
> they do and searched a bit in ODF but didn't find much. So here is some basics to \
> have positioning and sizing (which is a TODO right now). 
> I'd love to have some API review, see what stuff is missing etc.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWView.h 1127877 
> trunk/koffice/kword/part/KWView.cpp 1127877 
> trunk/koffice/kword/part/kword.rc 1127877 
> trunk/koffice/libs/flake/CMakeLists.txt 1127877 
> trunk/koffice/libs/flake/KoTextOnShapeContainer.h PRE-CREATION 
> trunk/koffice/libs/flake/KoTextOnShapeContainer.cpp PRE-CREATION 
> trunk/koffice/libs/flake/KoTextShapeDataBase.h PRE-CREATION 
> trunk/koffice/libs/flake/KoTextShapeDataBase.cpp PRE-CREATION 
> trunk/koffice/libs/flake/KoTextShapeDataBase_p.h PRE-CREATION 
> trunk/koffice/libs/kotext/KoTextShapeData.h 1127877 
> trunk/koffice/libs/kotext/KoTextShapeData.cpp 1127877 
> 
> Diff: http://reviewboard.kde.org/r/3988/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]