[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Grid colors can be set using the view menu and we
From:       "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date:       2010-06-16 22:04:54
Message-ID: 20100616220454.18649.89831 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4338/#review6156
-----------------------------------------------------------


Sorry for not answering this to your previous diff about this, but I don't really see \
why we need new ways to change settings that can already be changes. To show/hide the \
grid you can edit the sheet properties of a sheet, and in the Configure KSpread \
dialog there is already an option to change the color of the grid. So I don't think \
adding more ways to do the same thing would really gain us, and in this case would \
only clutter the menu.

- Marijn


On 2010-06-16 15:59:02, Srihari Prasad GV wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4338/
> -----------------------------------------------------------
> 
> (Updated 2010-06-16 15:59:02)
> 
> 
> Review request for KOffice, Boudewijn Rempt and Mani Chandrasekar.
> 
> 
> Summary
> -------
> 
> The grid color can be changed as per the users requirements. I have included the \
> previous patch as well, as it is still under review ie. Enabling show os hide grid. \
>  
> This addresses bugs 141406 and 181945.
> https://bugs.kde.org/show_bug.cgi?id=141406
> https://bugs.kde.org/show_bug.cgi?id=181945
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/kspread/kspread.rc 1136903 
> /trunk/koffice/kspread/kspread_readonly.rc 1136903 
> /trunk/koffice/kspread/part/View.h 1136903 
> /trunk/koffice/kspread/part/View.cpp 1136903 
> /trunk/koffice/kspread/part/dialogs/PreferenceDialog.cpp 1136903 
> 
> Diff: http://reviewboard.kde.org/r/4338/diff
> 
> 
> Testing
> -------
> 
> By executing the code
> 
> 
> Thanks,
> 
> Srihari
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]