[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Small KWord fix for continuous pages adding
From:       "Miroslav Nohaj" <miroslav.nohaj () ixonos ! com>
Date:       2010-06-02 6:51:51
Message-ID: 20100602065151.21375.4854 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4174/#review5949
-----------------------------------------------------------


Could anybody please take a look at it? It would be great if Thomas could...

- Miroslav


On 2010-05-28 16:23:29, Miroslav Nohaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4174/
> -----------------------------------------------------------
> 
> (Updated 2010-05-28 16:23:29)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> When the .odt document contains only one paragraph which contains something (i.e. \
> image) that is bigger than one page, the layout tries to add one page to make it \
> fit, but as that larger thing won't be put on the first page, the situation repeats \
> and it tries to add another page, and so on... 
> The patch checks if the next shapes (together) have enough space to hold the \
> current large thing and if they do, it will not try to add more pages. I know that \
> this might not the best solution so I'm awaiting some recommendations from Thomas \
> on what would be a better way to do it and as this patch will be probably remade, \
> it doesn't contain comments in the code.  
> 
> Diffs
> -----
> 
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1131075 
> 
> Diff: http://reviewboard.kde.org/r/4174/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miroslav
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]