[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Kword drawing order fix
From:       "Matus Hanzes" <matus.hanzes () ixonos ! com>
Date:       2010-06-01 14:52:55
Message-ID: 20100601145255.6040.19424 () localhost
[Download RAW message or body]



> On 2010-05-29 11:34:14, Thorsten Zachmann wrote:
> > trunk/koffice/kword/part/frames/KWFrame.cpp, line 64
> > <http://reviewboard.kde.org/r/4173/diff/1/?file=27581#file27581line64>
> > 
> > This could also be archived by setting the zindex of the frame correctly or do I \
> > miss something. Maybe you would need to have a layer, to set the order correctly.
> 
> Matus Hanzes wrote:
> In odf "style:run-through" and "draw:z-index" are two different things and to \
> combine them into one zindex variable would be complicated in some cases. 
> I think that to anchor shapes to layers is not possible because they are already \
> anchored to Kword frames and Kword expects it. 
> It seems that this functionality is necessary only in Kword so change in KOShape \
> makes other applications unnecessary slower. Another option would be to have \
> different shape sorting function for Kword. 
> If you know how to implement "style:run-through" functionality differently please \
> explain it in more detail. 
> 
> Thomas Zander wrote:
> > If you know how to implement "style:run-through" functionality differently
> > please explain it in more detail.
> 
> Why do you give up so easy? 
> I don't know the way its supposed to behave with all the properties that you are \
> trying to make work. Maybe you can write down what odf-properties you want to use \
> and how that affects the shape stacking. Or in other words; do some more research \
> instead of asking volunteer developers to come up with the solution for you :)

I have posted solution so I don't think I want someone to come up with solution \
instead of me.

I have just reacted at your proposal that I should use KoShapeLayer.
I just didn't understand what you meant so I asked you to explain it in more detail.

The odf-propertie that I want to add is "style:run-through".

I agree that the solution I have posted looks like it is introducing duplicate \
concepts. But it is caused probably by wrong naming of functions in KoShape. I should \
use runThrought() function name instead of layer(). :(

Of course it is possible to add support for "style:run-through".property with help of \
KoShapeLayer, but it is in my opinion not possible without change of data structure \
concept inside Kword and I don't think that change in data concept is what you want.


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4173/#review5910
-----------------------------------------------------------


On 2010-05-28 15:09:25, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4173/
> -----------------------------------------------------------
> 
> (Updated 2010-05-28 15:09:25)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> KWOdfLoader
> Added support for loading of frame properties for objects anchored in header or \
> footer, but I am not sure it is the right way to do it. 
> KOshape
> Added support for something like layers, so that shape placed in lower layer are \
> drawn earlyer than shape in higher layer. 
> KWFrame
> Have added support for placing shapes in layers.
> 
> RunThrough-Backgrond is placed in layer -1.
> RunThrough-Foreground is placed in layer 1.
> All others runAround properties are placed in layer 0.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWOdfLoader.cpp 1131612 
> trunk/koffice/kword/part/KWOdfSharedLoadingData.cpp 1131612 
> trunk/koffice/kword/part/KWord.h 1131612 
> trunk/koffice/kword/part/frames/KWFrame.h 1131612 
> trunk/koffice/kword/part/frames/KWFrame.cpp 1131612 
> trunk/koffice/libs/flake/KoShape.h 1131612 
> trunk/koffice/libs/flake/KoShape.cpp 1131612 
> trunk/koffice/libs/flake/KoShape_p.h 1131612 
> 
> Diff: http://reviewboard.kde.org/r/4173/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]