[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix for broken unit test
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-05-28 16:33:22
Message-ID: 20100528163322.22711.70580 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4169/#review5904
-----------------------------------------------------------
Ship it!
thanks for the fix :)
- Thomas
On 2010-05-28 09:04:24, Matus Hanzes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4169/
> -----------------------------------------------------------
>
> (Updated 2010-05-28 09:04:24)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> Unit test TestDocumentLayout is broken because KWPageTextInfo is always null in \
> KWAnchorStrategy::checkState. I have moved KWPageTextInfo is null check to another \
> place where it doesn't influence the unit test.
>
> Diffs
> -----
>
> trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1131451
>
> Diff: http://reviewboard.kde.org/r/4169/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matus
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic