From koffice-devel  Fri May 28 16:33:22 2010
From: "Thomas Zander" <zander () kde ! org>
Date: Fri, 28 May 2010 16:33:22 +0000
To: koffice-devel
Subject: Re: Review Request: Fix for broken unit test
Message-Id: <20100528163322.22711.70580 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=127506437127540


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4169/#review5904
-----------------------------------------------------------

Ship it!


thanks for the fix :)

- Thomas


On 2010-05-28 09:04:24, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4169/
> -----------------------------------------------------------
> 
> (Updated 2010-05-28 09:04:24)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Unit test TestDocumentLayout is broken because KWPageTextInfo is always null in KWAnchorStrategy::checkState.
> I have moved KWPageTextInfo is null check to another place where it doesn't influence the unit test.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1131451 
> 
> Diff: http://reviewboard.kde.org/r/4169/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel