[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: VectorShape fix
From:       "Matus Hanzes" <matus.hanzes () ixonos ! com>
Date:       2010-05-27 9:21:19
Message-ID: 20100527092119.4758.10797 () localhost
[Download RAW message or body]



> On 2010-05-27 08:54:19, Thorsten Zachmann wrote:
> > Wouldn't it be better to fix the mismatch of save and restore as doing it wrongly \
> > has certainly problems as sometimes the state is not what you expect if a restore \
> > has not happened.

Problem is that it depeds directly on what is inside wmf file, and it is possible \
that some wmf files are not corrert.


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4164/#review5886
-----------------------------------------------------------


On 2010-05-27 06:59:08, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4164/
> -----------------------------------------------------------
> 
> (Updated 2010-05-27 06:59:08)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Sometimes VectorShape calls QPainter::save() function more times than \
> QPainter::restore(). It can cause problems when another shape is using the same \
> QPainter.  For example in KoShapeManager::paint().
> 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/libkowmf/kowmfpaint.h 1131052 
> trunk/koffice/filters/libkowmf/kowmfpaint.cc 1131052 
> 
> Diff: http://reviewboard.kde.org/r/4164/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]