[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: bug fix "Text displayed at wrong place in this
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-05-25 20:05:28
Message-ID: 20100525200528.17972.38364 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3699/#review5868
-----------------------------------------------------------

Ship it!


Looks good, thanks.
If you can fix the little details mentioned below and make sure that the unit tests \
in kword all still pass then please commit :)


trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp
<http://reviewboard.kde.org/r/3699/#comment5495>

    Probably faster to do using kwordDocument()->mainFrameSet()



trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp
<http://reviewboard.kde.org/r/3699/#comment5496>

    Probably faster to do using;
    KWPage current = frameSet->pageManager().page(m_currentLineY);
    if (frameSet->pageManager().page(frame->shape()) == current) {  /* found frame \
*/}


- Thomas


On 2010-05-25 09:39:57, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3699/
> -----------------------------------------------------------
> 
> (Updated 2010-05-25 09:39:57)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> To place draw objects properly in kword document I needed to add more support for \
> anchoring in kword.(style:vertical-pos,style:vertical-rel,style:horizontal-pos,style:vertical-rel)
>  I tried to make anchoring backward compatible.
> 
> Comments are welcome.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWPageStyle.h 1130405 
> trunk/koffice/kword/part/KWPageStyle.cpp 1130405 
> trunk/koffice/kword/part/KWPageStyle_p.h 1130405 
> trunk/koffice/kword/part/KWPageTextInfo.h 1130405 
> trunk/koffice/kword/part/KWPageTextInfo.cpp 1130405 
> trunk/koffice/kword/part/frames/KWAnchorStrategy.h 1130405 
> trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1130405 
> trunk/koffice/kword/part/frames/KWFrameLayout.cpp 1130405 
> trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1130405 
> trunk/koffice/libs/kotext/KoTextAnchor.h 1130405 
> trunk/koffice/libs/kotext/KoTextAnchor.cpp 1130405 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1130405 
> 
> Diff: http://reviewboard.kde.org/r/3699/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]