[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: bug fix "Text displayed at wrong place in this
From:       "Matus Hanzes" <matus.hanzes () ixonos ! com>
Date:       2010-05-25 10:52:35
Message-ID: 20100525105235.3792.54795 () localhost
[Download RAW message or body]



> On 2010-05-25 10:26:51, Thorsten Zachmann wrote:
> > trunk/koffice/libs/kotext/KoTextAnchor.cpp, line 650
> > <http://reviewboard.kde.org/r/3699/diff/5/?file=27469#file27469line650>
> > 
> > What will happen in case false is returned? Will we loose information or even \
> > stop loading?

Return value is not handled.
We will lose the anchor position and there will be default anchor position for this \
anchor type.


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3699/#review5852
-----------------------------------------------------------


On 2010-05-25 09:39:57, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3699/
> -----------------------------------------------------------
> 
> (Updated 2010-05-25 09:39:57)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> To place draw objects properly in kword document I needed to add more support for \
> anchoring in kword.(style:vertical-pos,style:vertical-rel,style:horizontal-pos,style:vertical-rel)
>  I tried to make anchoring backward compatible.
> 
> Comments are welcome.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWPageStyle.h 1130405 
> trunk/koffice/kword/part/KWPageStyle.cpp 1130405 
> trunk/koffice/kword/part/KWPageStyle_p.h 1130405 
> trunk/koffice/kword/part/KWPageTextInfo.h 1130405 
> trunk/koffice/kword/part/KWPageTextInfo.cpp 1130405 
> trunk/koffice/kword/part/frames/KWAnchorStrategy.h 1130405 
> trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1130405 
> trunk/koffice/kword/part/frames/KWFrameLayout.cpp 1130405 
> trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1130405 
> trunk/koffice/libs/kotext/KoTextAnchor.h 1130405 
> trunk/koffice/libs/kotext/KoTextAnchor.cpp 1130405 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1130405 
> 
> Diff: http://reviewboard.kde.org/r/3699/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]