[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add handling of number definitions,
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-05-22 10:21:40
Message-ID: 20100522102140.32622.87303 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4063/#review5829
-----------------------------------------------------------



trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.h
<http://reviewboard.kde.org/r/4063/#comment5473>

    Missing 'or later' which is required for koffice-libs additions.



trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.h
<http://reviewboard.kde.org/r/4063/#comment5474>

    probably not good to refer to section numbers as those change between versions of \
ODF.



trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.h
<http://reviewboard.kde.org/r/4063/#comment5475>

    Please remove copyrighted text coming from the ODF specification.



trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.h
<http://reviewboard.kde.org/r/4063/#comment5476>

    use 'isEnabled' makes more sense here following the API design book.



trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.cpp
<http://reviewboard.kde.org/r/4063/#comment5477>

    Please use QSharedData concept instead.



trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.cpp
<http://reviewboard.kde.org/r/4063/#comment5478>

    don't use 'isNull' in new code, thats a Qt3-ism



trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.cpp
<http://reviewboard.kde.org/r/4063/#comment5479>

    typo



trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.cpp
<http://reviewboard.kde.org/r/4063/#comment5480>

    where does that '10' come from?



trunk/koffice/libs/odf/KoOdfNotesConfiguration.cpp
<http://reviewboard.kde.org/r/4063/#comment5481>

    Please use QSharedData concept



trunk/koffice/libs/odf/KoOdfNumberDefinition.h
<http://reviewboard.kde.org/r/4063/#comment5482>

    please remove unused and unimplemented method.
    As I said in the previous review; only stuff that is actually used and needed and \
implemented should go into the libs.



trunk/koffice/libs/odf/KoOdfNumberDefinition.cpp
<http://reviewboard.kde.org/r/4063/#comment5483>

    Use QSharedData



trunk/koffice/libs/odf/KoOdfNumberDefinition.cpp
<http://reviewboard.kde.org/r/4063/#comment5485>

    please use QChar::unicode() == 'a' etc here which is much faster (see previous \
review for details)



trunk/koffice/libs/odf/KoOdfNumberDefinition.cpp
<http://reviewboard.kde.org/r/4063/#comment5486>

    QString::null is a Qt3-ism.  Use QString()


- Thomas


On 2010-05-20 11:23:20, Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4063/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 11:23:20)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Implement three classes:
> 
> * KoOdfNumberDefinition: makes it easy to load and save numbering definitions from \
>                 ODF, as used in line numbering, notes numbering and other places
> * KoOdfLineNumberingConfingration: load and save the numbering definitions for line \
>                 numbering.
> * KoOdfNotesConfiguration: load and save the configuration for showing footnotes \
> and endnotes. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/odf/CMakeLists.txt 1128791 
> trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.h PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfLineNumberingConfiguration.cpp PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfNotesConfiguration.h PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfNotesConfiguration.cpp PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfNumberDefinition.h PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfNumberDefinition.cpp PRE-CREATION 
> trunk/koffice/libs/odf/KoOdfStylesReader.h 1128791 
> trunk/koffice/libs/odf/KoOdfStylesReader.cpp 1128791 
> 
> Diff: http://reviewboard.kde.org/r/4063/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]