[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Use number definition,
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-05-22 10:07:19
Message-ID: 20100522100719.32333.7793 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4064/#review5828
-----------------------------------------------------------



trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp
<http://reviewboard.kde.org/r/4064/#comment5472>

    This structure looks wrong, storing the configuration on each and every \
KoTextDocument means duplication and it means that you have to adjust all code that \
creates new text-documents.  
    For instance inserting a new text-shape in KWord would not get this \
configuration.  
    I think the configuration should not be stored on each document again, especially \
since altering the config in a UI means we have to fetch all KoTextDocuments and \
alter each instance of the config.


- Thomas


On 2010-05-20 11:29:20, Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4064/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 11:29:20)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Extends the KoText library with the following functionality:
> 
> * make it possible to retrieve all endnotes from the KoInlineObjectManager
> * make it possible to retrieve the global footnotes, endnotes and line numering \
>                 configuration from the KoTextDocument.
> * extends TextShapeData with types that show which role a particular text shape \
> plays on a page. This is needed to make it possible to figure out whether line \
> numbers should be painted or not inside a particular text shape. 
> * in the opendocument part of kotext:
> * load the notes and line numbering configuration
> 
> * in the styles part of kotext:
> 
> * use KoOdfNumberDefinition instead of custom code to parse the numbers
> * load the line number settings for paragraphcs
> 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/kotext/KoInlineTextObjectManager.h 1128791 
> trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp 1128791 
> trunk/koffice/libs/kotext/KoTextDocument.h 1128791 
> trunk/koffice/libs/kotext/KoTextDocument.cpp 1128791 
> trunk/koffice/libs/kotext/KoTextShapeData.h 1128791 
> trunk/koffice/libs/kotext/KoTextShapeData.cpp 1128791 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1128791 
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h 1128791 
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 1128791 
> trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1128791 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.h 1128791 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1128791 
> 
> Diff: http://reviewboard.kde.org/r/4064/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]