[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Insert a toc with the insert menu
From:       "Jean-Nicolas Artaud" <jeannicolasartaud () gmail ! com>
Date:       2010-05-21 14:30:41
Message-ID: 20100521143041.7672.73107 () localhost
[Download RAW message or body]



> On 2010-05-21 10:45:07, Thomas Zander wrote:
> > Thanks for this one, its one more step towards a good ToC implementation.
> > I added some comments that would be nice to solve before committing.

Thank you for this review.

I cannot answer all the comments for now (I have to look deeper in the code) but \
every one seems correct execpt the last one I have added a comment! A new patch will \
be proposed on wednesday, which means ASAP for me.


> On 2010-05-21 10:45:07, Thomas Zander wrote:
> > /trunk/koffice/plugins/textshape/ToCGenerator.cpp, line 112
> > <http://reviewboard.kde.org/r/4061/diff/1/?file=27248#file27248line112>
> > 
> > This line looks out of place for this patch and if that style doesn't exist will \
> > cause crashes so its probably not good to have here.

Maybe this line should be in another patch, it doesn't help in the generation.
Excepted that, I am pretty sure this line is necessary to avoid the crash in case of \
non loaded style! I do agree that the line of test of this currentStyle should be \
added.


- Jean-Nicolas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4061/#review5781
-----------------------------------------------------------


On 2010-05-20 08:27:15, Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4061/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 08:27:15)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Add the "insert a table of contents" in the insert menu.
> The screenshot shows the result, but the look is not the importance of this patch, \
> it only uses what was existing (with too much hard coded elements for sure) 
> 
> Diffs
> -----
> 
> /trunk/koffice/kword/part/KWView.h 1128772 
> /trunk/koffice/kword/part/KWView.cpp 1128772 
> /trunk/koffice/kword/part/kword.rc 1128772 
> /trunk/koffice/plugins/textshape/ToCGenerator.cpp 1128772 
> 
> Diff: http://reviewboard.kde.org/r/4061/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> toc insert
> http://reviewboard.kde.org/r/4061/s/406/
> 
> 
> Thanks,
> 
> Jean-Nicolas
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]