[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Insert a toc with the insert menu
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-05-21 10:45:02
Message-ID: 20100521104502.32702.85890 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4061/#review5781
-----------------------------------------------------------


Thanks for this one, its one more step towards a good ToC implementation.
I added some comments that would be nice to solve before committing.


/trunk/koffice/kword/part/KWView.cpp
<http://reviewboard.kde.org/r/4061/#comment5435>

    I don't think using m_document->mainFrameSet() makes much sense here.  First of \
all mainFrameSet may return zero so this can crash.  Second, I think using the main \
FS even if its not selected can lead to odd surprises.  
    I suggest to use the current selection if there is no handler.



/trunk/koffice/kword/part/KWView.cpp
<http://reviewboard.kde.org/r/4061/#comment5436>

    Just using insertBlock() is enough, no? Inserting semi-random text would be nice \
to avoid. :)



/trunk/koffice/kword/part/kword.rc
<http://reviewboard.kde.org/r/4061/#comment5437>

    Please also increase the version number at the top of the file.



/trunk/koffice/plugins/textshape/ToCGenerator.cpp
<http://reviewboard.kde.org/r/4061/#comment5438>

    This line looks out of place for this patch and if that style doesn't exist will \
cause crashes so its probably not good to have here.


- Thomas


On 2010-05-20 08:27:15, Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4061/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 08:27:15)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Add the "insert a table of contents" in the insert menu.
> The screenshot shows the result, but the look is not the importance of this patch, \
> it only uses what was existing (with too much hard coded elements for sure) 
> 
> Diffs
> -----
> 
> /trunk/koffice/kword/part/KWView.h 1128772 
> /trunk/koffice/kword/part/KWView.cpp 1128772 
> /trunk/koffice/kword/part/kword.rc 1128772 
> /trunk/koffice/plugins/textshape/ToCGenerator.cpp 1128772 
> 
> Diff: http://reviewboard.kde.org/r/4061/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> toc insert
> http://reviewboard.kde.org/r/4061/s/406/
> 
> 
> Thanks,
> 
> Jean-Nicolas
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]