[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Page numbers are not displayed properly in KWord
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2010-04-22 13:22:35
Message-ID: 20100422132235.3006.86247 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3472/#review5162
-----------------------------------------------------------

Ship it!


Looks good, except it should be generalized to footers as well.  Fix that and you can \
commit.


/trunk/koffice/filters/kword/msword-odf/paragraph.h
<http://reviewboard.kde.org/r/3472/#comment4657>

    This should be generalized to also support footers, like inHeaderFooter.  That's \
the way it's done in other places.  And that also goes for the member variable.


- Inge


On 2010-04-22 08:42:30, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3472/
> -----------------------------------------------------------
> 
> (Updated 2010-04-22 08:42:30)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch solves problems with page numbering in filter.
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/filters/kword/msword-odf/texthandler.h 1116396 
> /trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1116396 
> /trunk/koffice/filters/kword/msword-odf/paragraph.cpp 1116396 
> /trunk/koffice/filters/kword/msword-odf/paragraph.h 1116396 
> 
> Diff: http://reviewboard.kde.org/r/3472/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavol
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]