[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    FW: Review Request: Diagonal borders not retained in Kword
From:       Korinek Pavol <pavol.korinek () ixonos ! com>
Date:       2010-04-21 13:41:48
Message-ID: C495228385CC1D409A54846080C9CBA568B3848C99 () jklmail01 ! ixonos ! local
[Download RAW message or body]

I was thinking about that too. This, as I published, looked best solution to me. I can not exactly explain some combination of that two models. I have test it. If SPRM::sprmTSetBrc was used only for diagonal borders. Other borders like top, left, .. was set for whole table. KWord draw them too, also if I have used separate model. Anyway, this should be discussed. Thanks.

Pavol

-----Original Message-----
From: C. Boemann [mailto:cbo@boemann.dk] 
Sent: Wednesday, April 21, 2010 3:19 PM
To: Korinek Pavol; KOffice
Subject: Re: Review Request: Diagonal borders not retained in Kword

On Wednesday 21 April 2010 15:10:24 you wrote:
> > On 2010-04-21 12:52:51, Casper Boemann wrote:
> > > /trunk/koffice/filters/kword/msword-odf/tablehandler.cpp, line 353
> > > <http://reviewboard.kde.org/r/3700/diff/1/?file=24156#file24156line353>
> > > 
> > >     seems unused
> > >     bordermodel is a much more complicated issue
> 
> It's used on line 412.
ok i missed that. Anyway it's wrong to go to separate model in every case 
there is a border. Maybe if there are diagonal borders, but i'm not even sure 
that is a good enough metric.

> 
> > On 2010-04-21 12:52:51, Casper Boemann wrote:
> > > /trunk/koffice/libs/kotext/styles/KoTableCellStyle.cpp, line 786
> > > <http://reviewboard.kde.org/r/3700/diff/1/?file=24161#file24161line786>
> > > 
> > >     please check for valid border
> 
> same as above
what?

> 
> > On 2010-04-21 12:52:51, Casper Boemann wrote:
> > > /trunk/koffice/libs/kotext/styles/KoTableCellStyle.cpp, line 781
> > > <http://reviewboard.kde.org/r/3700/diff/1/?file=24161#file24161line781>
> > > 
> > >     please check for valid border
> 
> there was no other borders defined in /enum Side/ so I added there this
> two: TopLeftToBottomRight and BottomLeftToTopRight. Do we have some Ko
> specification for that ? I'd like to use some valid enum borders for that.
> In odf I have used: style:diagonal-tl-br and style:diagonal-bl-tr as is
> mentioned in odf specification.
> 
uhm, that was not an answer to the suggestion right?

anyway as far as those two enums, yes it looks correct.
> 
> - Pavol
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3700/#review5137
> -----------------------------------------------------------
> 
> On 2010-04-21 12:44:30, Pavol Korinek wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/3700/
> > -----------------------------------------------------------
> > 
> > (Updated 2010-04-21 12:44:30)
> > 
> > 
> > Review request for KOffice.
> > 
> > 
> > Summary
> > -------
> > 
> > This is implementation of diagonal borders in filter, layout and kotext.
> > Let's say it's working version. Please ignore few kDebug lines which I
> > left there so far. I will remove them finally of course.
> > 
> > 
> > Diffs
> > -----
> > 
> >   /trunk/koffice/filters/kword/msword-odf/tablehandler.cpp 1116396
> >   /trunk/koffice/filters/kword/msword-odf/wv2/src/word97_generated.h
> >   1116396
> >   /trunk/koffice/filters/kword/msword-odf/wv2/src/word97_generated.cpp
> >   1116396
> >   /trunk/koffice/filters/kword/msword-odf/wv2/src/word97_helper.cpp
> >   1116396 /trunk/koffice/libs/kotext/styles/KoTableCellStyle.h 1116396
> >   /trunk/koffice/libs/kotext/styles/KoTableCellStyle.cpp 1116396
> > 
> > Diff: http://reviewboard.kde.org/r/3700/diff
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > Pavol


_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]