[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: fix bug #184036
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-03-30 12:26:43
Message-ID: 20100330122643.8045.61563 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3273/#review4775
-----------------------------------------------------------

Ship it!


It looks good to me, but and it seems to follow Thomas' instructions on bugzilla. So \
as far as I am concerned you can commit this bug fix.

- Boudewijn


On 2010-03-12 20:33:38, nadavvin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3273/
> -----------------------------------------------------------
> 
> (Updated 2010-03-12 20:33:38)
> 
> 
> Review request for KOffice and Thomas Zander.
> 
> 
> Summary
> -------
> 
> Can I commit?
> 
> 
> This addresses bug 41576.
> https://bugs.kde.org/show_bug.cgi?id=41576
> 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/kotext/KoTextEditor.h 1100824 
> trunk/koffice/libs/kotext/KoTextEditor.cpp 1100824 
> trunk/koffice/libs/kotext/KoTextShapeData.cpp 1100824 
> 
> Diff: http://reviewboard.kde.org/r/3273/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nadavvin
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]