[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: msword-odf filter: Fixed a bug in page-layout
From:       "Matus Uzak" <matus.uzak () ixonos ! com>
Date:       2010-03-19 12:18:59
Message-ID: 20100319121859.12848.64454 () localhost
[Download RAW message or body]



> On 2010-03-18 20:06:30, Casper Boemann wrote:
> > trunk/koffice/filters/kword/msword-odf/document.cpp, line 532
> > <http://reviewboard.kde.org/r/3318/diff/3/?file=20976#file20976line532>
> > 
> > this should be delete too then

I understand you are not confident with this in general.  I'm rewriting the code \
actually to implement the next-style-name attribute for <master-page>.  I needed to \
fix this to continue.  The point was that there were two <page-layout> styles \
inserted into the styles collection (namely "pm1" and "Mpm").  And "pm1" instead of \
"Mpm" was assigned to the master-page, which was created.        

The m_masterStyle object was already deleted in the slotSectionFound function.  \
There's just a pointer into the styles collection.

Using Q_ASSERT now.    


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3318/#review4554
-----------------------------------------------------------


On 2010-03-18 15:27:30, Matus Uzak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3318/
> -----------------------------------------------------------
> 
> (Updated 2010-03-18 15:27:30)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Wrong pointer was used to add page-layout attributes.  Then a different page-layout \
> was assigned to the master-page.     
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kword/msword-odf/document.cpp 1104431 
> 
> Diff: http://reviewboard.kde.org/r/3318/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]