[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: msword-odf filter: Fixed a bug in page-layout
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-03-18 20:06:25
Message-ID: 20100318200625.10948.89133 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3318/#review4554
-----------------------------------------------------------


In general I'm not totally confident with this. Can you please explain why this is \
needed and why you have solved it like this.


trunk/koffice/filters/kword/msword-odf/document.cpp
<http://reviewboard.kde.org/r/3318/#comment4000>

    please use the Qt version



trunk/koffice/filters/kword/msword-odf/document.cpp
<http://reviewboard.kde.org/r/3318/#comment4001>

    this should be delete too then


- Casper


On 2010-03-18 15:27:30, Matus Uzak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3318/
> -----------------------------------------------------------
> 
> (Updated 2010-03-18 15:27:30)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Wrong pointer was used to add page-layout attributes.  Then a different page-layout \
> was assigned to the master-page.     
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kword/msword-odf/document.cpp 1104431 
> 
> Diff: http://reviewboard.kde.org/r/3318/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]