[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Picture bullets
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-02-20 23:34:51
Message-ID: 20100220233451.29601.82383 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3031/
-----------------------------------------------------------

(Updated 2010-02-20 23:34:51.493658)


Review request for KOffice.


Changes
-------

main change is storing the key of the KoImageData instead of a QPixmap

other comments also fixed except where something else was agreed on irc.


Summary
-------

Support for picture bullets
 - load from odf
 - use image collection
 - however this means a a shapeLoadingContext is required in many places instead of a odfLoadingContext

the patch doesn't include relatede changes (on liners) in every application
the path doesn't include the painting code either (though i have it working :) )


Diffs (updated)
-----

  trunk/koffice/libs/kotext/KoTextDocumentLayout.h 1090166 
  trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1090166 
  trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h 1090166 
  trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 1090166 
  trunk/koffice/libs/kotext/opendocument/tests/TestLoading.cpp 1090166 
  trunk/koffice/libs/kotext/styles/KoListLevelProperties.h 1090166 
  trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1090166 
  trunk/koffice/libs/kotext/styles/KoListStyle.h 1090166 
  trunk/koffice/libs/kotext/styles/KoListStyle.cpp 1090166 

Diff: http://reviewboard.kde.org/r/3031/diff


Testing
-------


Thanks,

Casper

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]