[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Picture bullets
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-02-20 19:37:32
Message-ID: 20100220193732.25165.10444 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3031/#review4231
-----------------------------------------------------------


thanks for some really nice cooperative work :)


trunk/koffice/libs/kotext/styles/KoListLevelProperties.h
<http://reviewboard.kde.org/r/3031/#comment3761>

    In this API we should likely use a QImage, not a pixmap.  A QPixmap requires a \
windowing system to be present and limits bit depths etc.  Also for naming \
consistency I suggest something with 'image' in there (follwing KoImageCollection)



trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp
<http://reviewboard.kde.org/r/3031/#comment3762>

    its not unused



trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp
<http://reviewboard.kde.org/r/3031/#comment3767>

    The image collection can be null for certain applications, please don't crash \
then.



trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp
<http://reviewboard.kde.org/r/3031/#comment3765>

    nice independent bugfix ;)



trunk/koffice/libs/kotext/styles/KoListStyle.h
<http://reviewboard.kde.org/r/3031/#comment3766>

    I think ImageItem makes more sense, to avoid bitmap/pixmap/picture naming for all \
the same thing I suggest we follow the KoImageCollection naming and just call it \
'image' everywhere.



trunk/koffice/libs/kotext/styles/KoListStyle.h
<http://reviewboard.kde.org/r/3031/#comment3763>

    The name 'Width' or 'Height' can be applied to different things too, I think to \
avoid people misusing this property we should make it longer. ImageWidth / \
ImageHeight for example



trunk/koffice/libs/kotext/styles/KoListStyle.h
<http://reviewboard.kde.org/r/3031/#comment3764>

    I would go with 'Image', pixmap is too implementation specific.


- Thomas


On 2010-02-20 19:13:47, Casper Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3031/
> -----------------------------------------------------------
> 
> (Updated 2010-02-20 19:13:47)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Support for picture bullets
> - load from odf
> - use image collection
> - however this means a a shapeLoadingContext is required in many places instead of \
> a odfLoadingContext 
> the patch doesn't include relatede changes (on liners) in every application
> the path doesn't include the painting code either (though i have it working :) )
> 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1090166 
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h 1090166 
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 1090166 
> trunk/koffice/libs/kotext/opendocument/tests/TestLoading.cpp 1090166 
> trunk/koffice/libs/kotext/styles/KoListLevelProperties.h 1090166 
> trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1090166 
> trunk/koffice/libs/kotext/styles/KoListStyle.h 1090166 
> trunk/koffice/libs/kotext/styles/KoListStyle.cpp 1090166 
> 
> Diff: http://reviewboard.kde.org/r/3031/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Casper
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]