[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/kword/part
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2010-02-19 8:31:50
Message-ID: 201002190931.50342.boud () valdyas ! org
[Download RAW message or body]

On Friday 19 February 2010, Thomas Zander wrote:
> On Friday 19. February 2010 08.59.06 Boudewijn Rempt wrote:
> > On Friday 19 February 2010, Thomas Zander wrote:
> > > The properties and APIs you removed are needed to at minimum
> > > save/restore ODF values without loosing them and also to do proper
> > > footnotes/endnotes layout. I don't really understand why you'd remove
> > > some 80 lines of code from KWord, at minimum without talking to me.
> > 
> > Arent these 80 lines of code things I had added myself in r1092387? I had
> > originally added them when I started my patch so I could implement them,
> > 
> >  but  then decided that it would be confusing to have them around until I
> >  got around to that.
> 
> Ok, so it was a commit + revert shortly after each other. Ok, thats fair
> enough, thanks for the quick reply to explain.

I still intend to implement at least roundtripping for these properties, so I 
didn't want to just delete all the work I had done on figuring them out, but 
neither did I want to clutter the code with it.

-- 
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]