[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: ToC generation step
From:       "Jean-Nicolas Artaud" <jeannicolasartaud () gmail ! com>
Date:       2010-01-28 8:40:43
Message-ID: 20100128084043.5608.22767 () localhost
[Download RAW message or body]



> On 2010-01-27 12:13:06, Pierre Ducroquet wrote:
> > trunk/koffice/libs/kotext/KoTextEditor.cpp, line 896
> > <http://reviewboard.kde.org/r/2734/diff/1/?file=17810#file17810line896>
> > 
> > That whole piece of code should be in KoTableOfContents, shouldn't it ?

I am working on that, it will help for style, and it is proper.


- Jean-Nicolas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2734/#review3906
-----------------------------------------------------------


On 2010-01-27 10:41:29, Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2734/
> -----------------------------------------------------------
> 
> (Updated 2010-01-27 10:41:29)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Here Is the ToC generation step.
> 
> http://img687.imageshack.us/img687/5207/tocgeneration.png
> 
> I think somethings have to be improved:
> * The style for instance are not really adapted, but if you open existing contents \
>                 styles, it works really good (see the screenshots).
> * pages number is not actually updated because a new signal is necessary : \
> layoutFinished 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWDocument.cpp 1079518 
> trunk/koffice/kword/part/kword.rc 1079518 
> trunk/koffice/libs/kotext/KoTextEditor.h 1080908 
> trunk/koffice/libs/kotext/KoTextEditor.cpp 1080908 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.h 1080908 
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1080908 
> trunk/koffice/plugins/textshape/TextTool.h 1079518 
> trunk/koffice/plugins/textshape/TextTool.cpp 1079518 
> 
> Diff: http://reviewboard.kde.org/r/2734/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jean-Nicolas
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]