[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: DataCenterMap
From:       Jan Hambrecht <jaham () gmx ! net>
Date:       2010-01-20 12:58:41
Message-ID: 4B56FE01.1060602 () gmx ! net
[Download RAW message or body]

On 20.01.2010 13:00, Thomas Zander wrote:
> On Wednesday 20. January 2010 12.30.42 Jan Hambrecht wrote:
>> I am ok with your changes, I have some minor issues though:
>>
>
> Cool :)
>
>> +    UndoStackResource,      ///<  The document-wide undo stack (KUndoStack)
>> +    ChangeTrackerResource = KoDocumentResource::KoTextStart + 1, ///<
>> KoChangeTracker
>>
>> Can we have a consistent name scheme for the resource ids please?
>
> I don't follow; what is inconsistent about using;
> UndoStackResource next to ChangeTrackerResource ?

Well if you look at all other resource id names, you will notice the 
difference. These two are different to all the other names.

>
>
>> +            , hasExternalDataCenterMap(false),
>> +            resourceManager(0)
>>
>> Please put the comma in front. (KarbonDocument.cpp)
>
> If I have to work on all of KOffice sourcecode I'm following the coding style. I
> thought we agreed on using that everywhere. Can we avoid exceptions for
> certain apps? That would be very useful :)

I am not sure that is handled by the coding style. So please use the one 
that is already present in that file.

Ciao Jan
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]