[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: DataCenterMap
From:       Thomas Zander <zander () kde ! org>
Date:       2010-01-20 12:00:44
Message-ID: 201001201300.44393.zander () kde ! org
[Download RAW message or body]

On Wednesday 20. January 2010 12.30.42 Jan Hambrecht wrote:
> I am ok with your changes, I have some minor issues though:
> 

Cool :)

> +    UndoStackResource,      ///< The document-wide undo stack (KUndoStack)
> +    ChangeTrackerResource = KoDocumentResource::KoTextStart + 1, ///< 
> KoChangeTracker
> 
> Can we have a consistent name scheme for the resource ids please?

I don't follow; what is inconsistent about using;
UndoStackResource next to ChangeTrackerResource ?


> +            , hasExternalDataCenterMap(false),
> +            resourceManager(0)
> 
> Please put the comma in front. (KarbonDocument.cpp)

If I have to work on all of KOffice sourcecode I'm following the coding style. I 
thought we agreed on using that everywhere. Can we avoid exceptions for 
certain apps? That would be very useful :)

> +void KarbonDocument::setResourceManager(KoResourceManager *rm)
> +{
> +    //delete d->resourceManager;
> +    d->resourceManager = rm;
> +}
> 
> Did you forget to remove the comment?

Yap, good catch :)
 
> +/// The kword-global namespace for all KWord related things.
> +namespace KPresenter
> 
> You probably mean kpresenter instead of kword|KWord.

Yes, copy paste error. Thanks for spotting!

Will fix these when I get back to my laptop.
-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]