[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Added Fremantle Office viewer code to tools/
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-01-04 20:38:41
Message-ID: 20100104203841.9814.11833 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2300/#review3574
-----------------------------------------------------------



trunk/koffice/tools/f-office/aboutdialog.ui
<http://reviewboard.kde.org/r/2300/#comment2839>

    remove this, as it will be translated without reason



trunk/koffice/tools/f-office/aboutdialog.ui
<http://reviewboard.kde.org/r/2300/#comment2840>

    remove this, as it will be translated without reason



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2841>

    methods start with lowercase char



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2842>

    why do you delete QObjects? m_FSTimer for example.



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2843>

    missing i18n



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2845>

    missing i18n



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2844>

    missing i18n



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2846>

    does this work?  I think you want a case-insensitive compare.



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2847>

    case insensitive needed?



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2848>

    this can't be translated like this. Use % and arguments.



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2849>

    i18n missing



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2850>

    i18n missing



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2851>

    i18n missing



trunk/koffice/tools/f-office/mainwindow.cpp
<http://reviewboard.kde.org/r/2300/#comment2852>

    i18n missing


- Thomas


On 2010-01-04 12:47:50, Mani Chandrasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2300/
> -----------------------------------------------------------
> 
> (Updated 2010-01-04 12:47:50)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Added Fremantle Office viewer code for maemo5.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/tools/f-office/CMakeLists.txt PRE-CREATION 
>   trunk/koffice/tools/f-office/COPYING PRE-CREATION 
>   trunk/koffice/tools/f-office/FreOffice.desktop PRE-CREATION 
>   trunk/koffice/tools/f-office/FreOffice.qrc PRE-CREATION 
>   trunk/koffice/tools/f-office/aboutdialog.h PRE-CREATION 
>   trunk/koffice/tools/f-office/aboutdialog.cpp PRE-CREATION 
>   trunk/koffice/tools/f-office/aboutdialog.ui PRE-CREATION 
>   trunk/koffice/tools/f-office/com.nokia.FreOffice.service PRE-CREATION 
>   trunk/koffice/tools/f-office/common.h PRE-CREATION 
>   trunk/koffice/tools/f-office/dbusadaptor.h PRE-CREATION 
>   trunk/koffice/tools/f-office/dbusadaptor.cpp PRE-CREATION 
>   trunk/koffice/tools/f-office/hildonapplication.h PRE-CREATION 
>   trunk/koffice/tools/f-office/hildonapplication.cpp PRE-CREATION 
>   trunk/koffice/tools/f-office/hildonmenu.h PRE-CREATION 
>   trunk/koffice/tools/f-office/hildonmenu.cpp PRE-CREATION 
>   trunk/koffice/tools/f-office/images/178x200/freoffice.png UNKNOWN 
>   trunk/koffice/tools/f-office/images/26x26/general_copy.png UNKNOWN 
>   trunk/koffice/tools/f-office/images/48x48/freoffice_document.png UNKNOWN 
>   trunk/koffice/tools/f-office/images/48x48/freoffice_presentation.png UNKNOWN 
>   trunk/koffice/tools/f-office/images/48x48/freoffice_text_selection.png UNKNOWN 
>   trunk/koffice/tools/f-office/images/64x64/freoffice.png UNKNOWN 
>   trunk/koffice/tools/f-office/main.cpp PRE-CREATION 
>   trunk/koffice/tools/f-office/mainwindow.h PRE-CREATION 
>   trunk/koffice/tools/f-office/mainwindow.cpp PRE-CREATION 
>   trunk/koffice/tools/f-office/mainwindow.ui PRE-CREATION 
>   trunk/koffice/tools/f-office/notifydialog.h PRE-CREATION 
>   trunk/koffice/tools/f-office/notifydialog.cpp PRE-CREATION 
>   trunk/koffice/tools/f-office/splash.h PRE-CREATION 
>   trunk/koffice/tools/f-office/splash.cpp PRE-CREATION 
>   trunk/koffice/tools/f-office/zoomdialog.h PRE-CREATION 
>   trunk/koffice/tools/f-office/zoomdialog.cpp PRE-CREATION 
>   trunk/koffice/tools/f-office/zoomdialog.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/2300/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mani
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]