[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Added Fremantle Office viewer code to tools/
From:       Thomas Zander <zander () kde ! org>
Date:       2010-01-04 20:10:42
Message-ID: 201001042110.43504.zander () kde ! org
[Download RAW message or body]

On Monday 4. January 2010 13.47.50 Mani Chandrasekar wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2300/
> -----------------------------------------------------------
> 
> (Updated 2010-01-04 12:47:50.737438)
> 
> 
> Review request for KOffice.
> 
> 
> Changes
> -------
> 
> Added i18n and removed trailing spaces.
> 
> Is there any thing i need to do apart from using i18n()?

Yes, see techbase.kde.org for a tutorial on how to make something 
translatable. At minimum we are missing an Messages.sh to extract the strings.
I noticed a rather big piece of html being wrapped in one i18n, maybe that can 
be made a bit more friendly to translators too?

Next to that, several other points were made in this thread that don't seem to 
have been looked into yet.  Is that something you planned to do?
To recap. The filenames should be CamelCase. The coding style should be 
honored. Maybe run astyle.

Also I just noticed we need to have a check that makes sure we only try to 
compile this on X11 as the code uses X11 directly instead of using Qt for 
those parts.

-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]